bevy icon indicating copy to clipboard operation
bevy copied to clipboard

Fix `asset-source-website.patch` line number

Open BD103 opened this issue 1 year ago • 2 comments

Objective

  • Ever since #13177, the check-example-showcase-patches-still-work job has been failing in the merge queue.
  • Specifically, the asset-source-website.patch file which modifies bevy_asset's lib.rs.

Solution

  • Re-create the patch.
    • Due to new content being added, the line numbers were off.
  • Also, turns out that typos was checking patch files. This turned into a CI error, so I disabled that too. Patches shouldn't really be modified manually, the original source should be. (Also it was erroring on the commit hash.)

Testing

  • Test the new patch works by running git apply tools/example-showcase/asset-source-website.patch.
  • Verify the merge queue passes with the check-example-showcase-patches-still-work job succeeding.

BD103 avatar May 09 '24 00:05 BD103

CI appeared to be failing because typos thought the commit number was a typo. I've excluded patch files from this check for the future.

BD103 avatar May 09 '24 00:05 BD103

Marking this as trivial :)

BD103 avatar May 09 '24 23:05 BD103