bevy icon indicating copy to clipboard operation
bevy copied to clipboard

Add `rust-version` field to `bevy_mikktspace`

Open BD103 opened this issue 9 months ago • 3 comments

bevy_mikktspace documents that it requires at least Rust 1.52.1.

https://github.com/bevyengine/bevy/blob/ff8a9b2a64d4d34ceb359edbf80298dcd5f9c9fb/crates/bevy_mikktspace/README.md?plain=1#L13

This should be codified by adding the rust-version field to Cargo.toml.

BD103 avatar May 02 '24 15:05 BD103

Bonus points if you also check if any other crates do not specify a rust-version. :) (Most should say rust-version.workspace = true!)

BD103 avatar May 02 '24 15:05 BD103

bevy_mikktspace is using the 2021 Rust edition. This makes it's minimum supported version Rust 1.56.0. The documentation will need to be updated.

Brezak avatar May 03 '24 15:05 Brezak

Bonus points if you also check if any other crates do not specify a rust-version. :) (Most should say rust-version.workspace = true!)

Turns out workspace-inherited properties are quite incompatible with our compile fail tests. If that were fixed, a lot of duplicated metadata could be merged...

BD103 avatar May 09 '24 00:05 BD103