bevy icon indicating copy to clipboard operation
bevy copied to clipboard

Update glam version requirement from 0.25 to 0.27

Open mnmaita opened this issue 1 year ago • 7 comments
trafficstars

Objective

  • Update glam version requirement to latest version.

Solution

  • Updated glam version requirement from 0.25 to 0.27.
  • Updated encase and encase_derive_impl version requirement from 0.7 to 0.8.
  • Updated hexasphere version requirement from 10.0 to 12.0.
  • Breaking changes from glam changelog:
    • [0.26.0] Minimum Supported Rust Version bumped to 1.68.2 for impl From for {f32,f64} support.
    • [0.27.0] Changed implementation of vector fract method to match the Rust implementation instead of the GLSL implementation, that is self - self.trunc() instead of self - self.floor().

Migration Guide

  • When using glam exports, keep in mind that vector fract() method now matches Rust implementation (that is self - self.trunc() instead of self - self.floor()). If you want to use the GLSL implementation you should now use fract_gl().

mnmaita avatar Mar 28 '24 03:03 mnmaita

Bevy does re-export structs from glam, right? If so, I'm wondering if I should add a migration guide along the lines of "keep in mind that vector fract method now matches Rust implementation. If you want to use GLSL implementation use fract_gl()".

~I also see several errors popping up in CI so I'll check them later.~ encase seems to need a version bump before we can merge this. See https://github.com/teoxoy/encase/pull/70.

mnmaita avatar Mar 28 '24 03:03 mnmaita

this PR should also update hexasphere to 0.12, and is blocked on encase releasing an updated version using glam 0.27

mockersf avatar Mar 28 '24 23:03 mockersf

this PR should also update hexasphere to 0.12, and is blocked on encase releasing an updated version using glam 0.27

Pushed an update to bump hexaspere version requirement. We'll wait for a new encase release then. Thanks!

mnmaita avatar Mar 29 '24 01:03 mnmaita

Just published encase v0.8.

teoxoy avatar Apr 24 '24 10:04 teoxoy

Thanks a lot for the release and the ping @teoxoy! This should be ready to be reviewed now @mockersf. Would you also be able to clarify if there will be any potential breaking changes that require migration? Please check my first comment for context.

mnmaita avatar Apr 25 '24 10:04 mnmaita

Would you also be able to clarify if there will be any potential breaking changes that require migration? Please check my first comment for context.

I think it's very niche, but it certainly doesn't hurt to mention it

mockersf avatar Apr 27 '24 00:04 mockersf

@mockersf rebased and updated the Migration Guide with some details on glam breaking changes. Should be good to merge now.

mnmaita avatar Apr 30 '24 01:04 mnmaita

@alice-i-cecile Can we just commit that suggested change and add this to the queue? It's a one liner, and this is blocking some other stuff.

NthTensor avatar May 02 '24 17:05 NthTensor

@alice-i-cecile Can we just commit that suggested change and add this to the queue? It's a one liner, and this is blocking some other stuff.

Commited the change and rebased. @alice-i-cecile @mockersf we should be able to merge now.

mnmaita avatar May 02 '24 18:05 mnmaita