bevy icon indicating copy to clipboard operation
bevy copied to clipboard

Enable the `unsafe_op_in_unsafe_fn` lint

Open tguichaoua opened this issue 1 year ago • 1 comments

What problem does this solve or what need does it fill?

unsafe_op_in_unsafe_fn will be warn by default in rust edition 2024 (https://github.com/rust-lang/rust/pull/112038).

What solution would you like?

Enable unsafe_op_in_unsafe_fn.

Additional context

I have opened a PR (#11591) that enables the lint at workspace level and fixes the lint in some crates. Nevertheless, the clippy::undocumented-unsafe-blocks lint makes unsafe blocks require a safety comment to describe them. The following crates require someone with enough knowledge about them to provide proper safety comments.

  • [x] bevy_dynamic_plugin #11622
  • [ ] bevy_ecs
  • [x] bevy_ptr #11610

tguichaoua avatar Jan 28 '24 21:01 tguichaoua

Linking to RFC 2585, which provides further motivation and details on the change.

BD103 avatar Jan 29 '24 16:01 BD103