bevy icon indicating copy to clipboard operation
bevy copied to clipboard

Published 20 hours ago • verified publisher icon bevyengine

Shrink prelude (Adopted)

Open tygyh opened this issue 1 year ago • 5 comments
trafficstars

Objective

  • Finish #3440
  • Separate code targeting 2d from code targeting 3d.

Solution

  • Split the prelude into prelude_2d, prelude_3d and a common part

tygyh avatar Jan 26 '24 18:01 tygyh

Which PR was this adopted from? We should link it here and close it out.

alice-i-cecile avatar Jan 26 '24 18:01 alice-i-cecile

Which PR was this adopted from? We should link it here and close it out.

I've seen it before, it's #3440

matiqo15 avatar Jan 26 '24 18:01 matiqo15

looking into how the examples were updated, this feels like a downgrade to me

mockersf avatar Jan 27 '24 13:01 mockersf

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Could you add some context on what users should update when this change get released in a new version of Bevy? It will be used to help writing the migration guide for the version. Putting it after a ## Migration Guide will help it get automatically picked up by our tooling.

github-actions[bot] avatar Jan 27 '24 13:01 github-actions[bot]

I'm personally not a fan. I can't find any discussion on why this is necessary besides "can cause name clashes when building third party crates". What is the motivation for splitting the prelude?

JMS55 avatar Jan 28 '24 06:01 JMS55

What is the motivation for splitting the prelude?

I adopted it because it was left open. I will close this since no one seems to be in favour of the changes.

tygyh avatar Feb 01 '24 21:02 tygyh