bevy-website
bevy-website copied to clipboard
Update zola
The 0.16.1 version of zola has a bug when using colocated_path, this prevents usage of image resolution in #710
Solution: upgrade the zola action we use.
The diff of the github action is available at:
https://github.com/shalzz/zola-deploy-action/compare/v0.16.1-1...v0.17.2
Unblocks #710
hhhmm, something broke with the update
some changes from https://github.com/bevyengine/bevy-website/pull/601 may be needed
@nicopap, do you still plan on working toward updating this PR? If not I'd like to adopt this PR and work on this.
Few things that may need changed in order to update to 0.17:
- Built-in shortcodes have been removed. Do we use any?
-
index.md
and_index.md
file can no longer be in the same folder. This can be checked by simple building with Zola 0.17. - If any images get processed, their filename now incorporates their hash. This will break any direct links to these images. Do we use image processing?
-
author
is now a first-class property, and can be moved out from the[extra]
table in various articles under thenews
folder. -
/
is Sass is not longer a division operator. It has been changed to now be a list separator. There are two solutions to this:- Wrap divisions in
calc
:12px / 4px
tocalc(12px / 4px)
. - Use
math.div
:12px / 4px
tomath.div(12px, 4px)
.
- Wrap divisions in
Compiled from Zola's changelog and grass / Dart Sass's breaking changes.
Few things that may need changed in order to update to 0.17:
* Built-in shortcodes have been removed. Do we use any? * `index.md` and `_index.md` file can no longer be in the same folder. This can be checked by simple building with Zola 0.17. * If any images get processed, their filename now incorporates their hash. This will break any direct links to these images. Do we use image processing? * `author` is now a first-class property, and can be moved out from the `[extra]` table in various articles under the `news` folder. * `/` is Sass is **not longer a division operator**. It has been changed to now be a list separator. There are two solutions to this: * Wrap divisions in `calc`: `12px / 4px` to `calc(12px / 4px)`. * Use `math.div`: `12px / 4px` to `math.div(12px, 4px)`.
Compiled from Zola's changelog and grass / Dart Sass's breaking changes.
I don't think any of these affect the site (outside of updating the author
property). I've been running Zola 0.18.0 locally on the site this entire time and it runs. Only warnings I get are regarding wgsl
and shell
highlight languages not being found. (Makes me curious what error we were getting with updating before given my experience so far.)
I don't think any of these affect the site (outside of updating the
author
property). I've been running Zola 0.18.0 locally on the site this entire time and it runs. Only warnings I get are regardingwgsl
andshell
highlight languages not being found. (Makes me curious what error we were getting with updating before given my experience so far.)
I believe the Sass division operator is use, but I need to double-check.
Yeah, I contemplated updating this recently, and I was remembered why I didn't continue work on it. The website build stuff is spread across five git repositories, all written as rust build scripts. And I've no intention of touching that.
Yeah, I contemplated updating this recently, and I was remembered why I didn't continue work on it. The website build stuff is spread across five git repositories, all written as rust build scripts. And I've no intention of touching that.
Mm, fun. /sar I'll take that as an okay for adopting this PR then. What's the fifth repository? I can guess bevy-website
, bevy
(examples), bevy-assets
, and bevy-community
(used for peoples page).
Well, it might very well be 4 (four). It's not just a question of 4 repositories, but also the relevant code being spread accross several config files on each of those repositories, each with their own special structure.
I'm glad you are taking the rein though. Thank you so much!
Closed in favor of #1018