bevy-website icon indicating copy to clipboard operation
bevy-website copied to clipboard

Update zola

Open nicopap opened this issue 1 year ago • 2 comments

The 0.16.1 version of zola has a bug when using colocated_path, this prevents usage of image resolution in #710

Solution: upgrade the zola action we use.

The diff of the github action is available at:

https://github.com/shalzz/zola-deploy-action/compare/v0.16.1-1...v0.17.2

Unblocks #710

nicopap avatar Jul 16 '23 07:07 nicopap

hhhmm, something broke with the update

nicopap avatar Jul 16 '23 15:07 nicopap

some changes from https://github.com/bevyengine/bevy-website/pull/601 may be needed

mockersf avatar Jul 16 '23 16:07 mockersf

@nicopap, do you still plan on working toward updating this PR? If not I'd like to adopt this PR and work on this.

TrialDragon avatar Feb 16 '24 02:02 TrialDragon

Few things that may need changed in order to update to 0.17:

  • Built-in shortcodes have been removed. Do we use any?
  • index.md and _index.md file can no longer be in the same folder. This can be checked by simple building with Zola 0.17.
  • If any images get processed, their filename now incorporates their hash. This will break any direct links to these images. Do we use image processing?
  • author is now a first-class property, and can be moved out from the [extra] table in various articles under the news folder.
  • / is Sass is not longer a division operator. It has been changed to now be a list separator. There are two solutions to this:
    • Wrap divisions in calc: 12px / 4px to calc(12px / 4px).
    • Use math.div: 12px / 4px to math.div(12px, 4px).

Compiled from Zola's changelog and grass / Dart Sass's breaking changes.

BD103 avatar Feb 16 '24 23:02 BD103

Few things that may need changed in order to update to 0.17:

* Built-in shortcodes have been removed. Do we use any?

* `index.md` and `_index.md` file can no longer be in the same folder. This can be checked by simple building with Zola 0.17.

* If any images get processed, their filename now incorporates their hash. This will break any direct links to these images. Do we use image processing?

* `author` is now a first-class property, and can be moved out from the `[extra]` table in various articles under the `news` folder.

* `/` is Sass is **not longer a division operator**. It has been changed to now be a list separator. There are two solutions to this:
  
  * Wrap divisions in `calc`: `12px / 4px` to `calc(12px / 4px)`.
  * Use `math.div`: `12px / 4px` to `math.div(12px, 4px)`.

Compiled from Zola's changelog and grass / Dart Sass's breaking changes.

I don't think any of these affect the site (outside of updating the author property). I've been running Zola 0.18.0 locally on the site this entire time and it runs. Only warnings I get are regarding wgsl and shell highlight languages not being found. (Makes me curious what error we were getting with updating before given my experience so far.)

TrialDragon avatar Feb 17 '24 05:02 TrialDragon

I don't think any of these affect the site (outside of updating the author property). I've been running Zola 0.18.0 locally on the site this entire time and it runs. Only warnings I get are regarding wgsl and shell highlight languages not being found. (Makes me curious what error we were getting with updating before given my experience so far.)

I believe the Sass division operator is use, but I need to double-check.

BD103 avatar Feb 17 '24 13:02 BD103

Yeah, I contemplated updating this recently, and I was remembered why I didn't continue work on it. The website build stuff is spread across five git repositories, all written as rust build scripts. And I've no intention of touching that.

nicopap avatar Feb 18 '24 17:02 nicopap

Yeah, I contemplated updating this recently, and I was remembered why I didn't continue work on it. The website build stuff is spread across five git repositories, all written as rust build scripts. And I've no intention of touching that.

Mm, fun. /sar I'll take that as an okay for adopting this PR then. What's the fifth repository? I can guess bevy-website, bevy (examples), bevy-assets, and bevy-community (used for peoples page).

TrialDragon avatar Feb 18 '24 17:02 TrialDragon

Well, it might very well be 4 (four). It's not just a question of 4 repositories, but also the relevant code being spread accross several config files on each of those repositories, each with their own special structure.

I'm glad you are taking the rein though. Thank you so much!

Closed in favor of #1018

nicopap avatar Feb 19 '24 07:02 nicopap