photo-editor icon indicating copy to clipboard operation
photo-editor copied to clipboard

Top tool bar - Done Button overlaps when moving element during text edit

Open BillCarsonFr opened this issue 7 years ago • 3 comments

Hello,

I just noticed that if you move an element (e.g sticker) while editing a text, when the you finish the move gesture both toolbar (top) and done button are displayed on screen.

Not sure if best way to stop it is to detect that there is a textView that is firstResponder in #moveView (state == ended) and then keep tool bars hidden, or to force end edit when a move is detected (on element that is not current text).

BTW, great work 👍

BillCarsonFr avatar Aug 04 '17 13:08 BillCarsonFr

Hi, i got this one too ^^

Great great work.

jeyremy avatar Nov 15 '17 15:11 jeyremy

UPDATE: of course @jeyremy you already pushed the PR!! https://github.com/eventtus/photo-editor/pull/19 thanks!

@BillCarsonFr or @jeyremy , did either of you guys fix this? If so, can you push a PR?

jonchui avatar Jul 27 '18 01:07 jonchui

@jonchui you are welcome ;)

jeyremy avatar Jul 27 '18 06:07 jeyremy