istextorbinary icon indicating copy to clipboard operation
istextorbinary copied to clipboard

Error resolving `path` when building bundle for browser with esbuild

Open wch opened this issue 3 years ago • 0 comments

I may be missing something obvious, but when I use istextorbinary and build for the browser, I get the following error:

 > node_modules/istextorbinary/edition-browsers/index.js:2:26: error: Could not resolve "path" (use "platform: 'node'" when building for node)
    2 │ import * as pathUtil from 'path';
      ╵                           ~~~~~~

Should it be importing from path?

Here's an example file test.ts:

import { isText } from "istextorbinary";
isText("test");

And here's what happens if you try to build it with esbuild --bundle:

$ esbuild test.ts --outfile=test.js --bundle
 > node_modules/istextorbinary/edition-browsers/index.js:2:26: error: Could not resolve "path" (use "--platform=node" when building for node)
    2 │ import * as pathUtil from 'path';
      ╵                           ~~~~~~

wch avatar May 23 '22 21:05 wch