horsey icon indicating copy to clipboard operation
horsey copied to clipboard

Published 20 hours ago • verified publisher icon bevacqua

Out-of-date browser support

Open akrawchyk opened this issue 8 years ago • 3 comments

Browser support includes every sane browser and IE7+.

I believe this statement in the README is incorrect. Even in the horsey.es5.js file, the ES6 Symbol is being used without a polyfill. Because of this, among other issues, horsey does not work on any version of IE.

akrawchyk avatar Oct 25 '16 20:10 akrawchyk

Also, I believe IE11 is barfing on this throw with error Object expected:

https://github.com/bevacqua/horsey/blob/master/dist/horsey.js#L434

screen shot 2016-10-25 at 4 52 58 pm

try -> catch -> finally -> try -> finally -> throw ( ⧉ ⦣ ⧉ )

akrawchyk avatar Oct 25 '16 20:10 akrawchyk

The culprit might be the for (... of ...) loop here https://github.com/bevacqua/horsey/blob/b975868e64b094b9369ed8722e508ed2b8cf3b37/horsey.js#L364 which looks like it's being transformed with babel or something to provide the feature with ES5.

akrawchyk avatar Oct 25 '16 21:10 akrawchyk

This also seems to be related https://github.com/babel/babel/issues/4451.

Specifically https://github.com/babel/babel/issues/4451#issuecomment-245415431 which looks similar to the bundled output.

akrawchyk avatar Oct 25 '16 21:10 akrawchyk