horsey icon indicating copy to clipboard operation
horsey copied to clipboard

No suggestions on IE11

Open waht opened this issue 8 years ago • 2 comments

On Internet Explorer 11 horsey fails to display suggestions. The developer console shows that on line 365 parent is undefined (an exception is thrown).

364:      for (let char of text) {
365:        parent.insertBefore(spanFor(char), el);
366:      }

I found out that document.createTreeWalker as used in getTextChildren is unsupported by IE (all versions according to MDN: https://developer.mozilla.org/de/docs/Web/API/Document/createTreeWalker). This seems to lead to parent being undefined.

waht avatar Aug 16 '16 11:08 waht

confirm. broken on ie.

korywka avatar Oct 12 '16 20:10 korywka

I have opened a PR fixing IE9+: https://github.com/bevacqua/horsey/pull/50

backflip avatar Nov 16 '16 10:11 backflip