betterlockscreen icon indicating copy to clipboard operation
betterlockscreen copied to clipboard

Published 20 hours ago • verified publisher icon betterlockscreen

Add date display

Open florentin-soubrand opened this issue 3 years ago • 10 comments

Description

Modified both main script and example config to add support for date on top of time. Only motivated by the need to have date when locked and by the simplicity of it.

Fixes # (issue)

How Has This Been Tested?

Since it's only built-in options in i3lock(-color), I just tested that without date options described in the personnal config the behaviour is the same as before my changes.

Checklist:

  • [x] I have performed a self-review of my own code/checked that ShellCheck succeeds
  • [x] I have made corresponding changes to the documentation (if applicable)
  • [x] The changes does not take effect by default

florentin-soubrand avatar Dec 15 '21 10:12 florentin-soubrand

I'm unsure why the pipeline fails (as the reported lines seems unchanged and next is building fine), as there are some issue related things to do I would take care of it as far as the pr is ready :)

SebTM avatar Dec 15 '21 11:12 SebTM

I'm unsure why the pipeline fails (as the reported lines seems unchanged and next is building fine), as there are some issue related things to do I would take care of it as far as the pr is ready :)

This was a problem from previous code with new version of shellcheck, now fixed

florentin-soubrand avatar Dec 16 '21 18:12 florentin-soubrand

The PR is ready you can merge it as soon as you like, if it fits you.

florentin-soubrand avatar Dec 22 '21 10:12 florentin-soubrand

Hello @florentin-soubrand ,

thanks for your contribution, please not the comments regarding your changes. There are not related changes to the date changes which should be separate PRs, beside that the date-option (as it is new) should have a value to turn off/be off by default which would match the current behavior.

Maybe I have time to adapt between the holiday - will try my best :)

SebTM avatar Dec 23 '21 04:12 SebTM

Hi @SebTM,

I removed the changes not related to the PR. And put the default theme example configuration to match the old one. To turn off/be off the option --date-str from i3lock must be an empty string, which it is by default

florentin-soubrand avatar Dec 24 '21 19:12 florentin-soubrand

nope

Uh... No?

jeffmhubbard avatar Dec 26 '21 22:12 jeffmhubbard

nope

Uh... No?

how did you separate date and time in two lines? I could only do in one line.

DerivativeMarmot avatar Jan 11 '22 02:01 DerivativeMarmot

Hey, thanks again for the contribution and sorry for my delay - as there seems still something wrong can you maybe rebase the PR and check it again? :)

SebTM avatar Feb 23 '22 22:02 SebTM

@SebTM, shall we rebase before continuing ?

florentin-soubrand avatar Feb 29 '24 21:02 florentin-soubrand

https://github.com/betterlockscreen/betterlockscreen/discussions/366#discussioncomment-8620664

SebTM avatar Mar 05 '24 11:03 SebTM