Rewrite buoy front end using Backbone.js

[hurtstotouchfire]

This rewrite should also improve the isolation of the front end with a view to extracting it into a small JS library that would facilitate possible back-end expansion (see #171, #172). This should also at least partially obsolete #64.

Goals:

• [x] improve DOM spaghetti
• [ ] clean up front end code so it ages better
  • [x] use Backbone for the Buoy Alert (buoy-alert.js) file
  • [ ] use Backbone for the incident view (chat room, etc); requires cleaning up the ugly "templates" thing we have right now
  • [ ] use Backbone for the Buoy Map (buoy-map.js) file, where it makes sense
• [ ] leverage some backbone features I've already forgotten the specifics about
• [ ] somehow this is good for the mobile app too I think

Scope:

• UI shell
• alerts
• chat UI
• does not include maps JS (right?)
• all new JS should have JS Docs

[hurtstotouchfire]

please edit this. I can't remember everything we discussed.

[fabacab]

CC'ing @mcverter, who's expressed an interest in helping with this process, too.

[fabacab]

@hurtstotouchfire Have a look at #190, which is a PR for the first line item here (which I'm marking "done") because it "improves DOM spaghetti." All I've done is DRY the references to containment-level HTML ids and class attributes.

If more, what else does "improve DOM spaghetti" actually mean?

[mcverter]

I am working on the javascript currently

On Dec 1, 2016 11:17 PM, "Meitar M." [email protected] wrote:

@hurtstotouchfire https://github.com/hurtstotouchfire Have a look at #190 https://github.com/betterangels/buoy/pull/190, which is a PR for the first line item here (which I'm marking "done") because it "improves DOM spaghetti." All I've done is DRY the references to containment-level HTML ids and class attributes.

If more, what else does "improve DOM spaghetti" actually mean?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/betterangels/buoy/issues/185#issuecomment-264369735, or mute the thread https://github.com/notifications/unsubscribe-auth/ABYvhLP6twfl29mV9njj5yMSoMDyl7SJks5rD5vWgaJpZM4K8B3R .

[mcverter]

What is being done by you all? Are we working on the same code?

On Dec 1, 2016 11:18 PM, "Mitchell Verter" [email protected] wrote:

I am working on the javascript currently

On Dec 1, 2016 11:17 PM, "Meitar M." [email protected] wrote:

@hurtstotouchfire https://github.com/hurtstotouchfire Have a look at #190 https://github.com/betterangels/buoy/pull/190, which is a PR for the first line item here (which I'm marking "done") because it "improves DOM spaghetti." All I've done is DRY the references to containment-level HTML ids and class attributes.

If more, what else does "improve DOM spaghetti" actually mean?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/betterangels/buoy/issues/185#issuecomment-264369735, or mute the thread https://github.com/notifications/unsubscribe-auth/ABYvhLP6twfl29mV9njj5yMSoMDyl7SJks5rD5vWgaJpZM4K8B3R .

[fabacab]

@mcverter Look at #190.

[mcverter]

Ah ok. I have been using those css selectors in the backbone.

[fabacab]

Now that #204 is merged I think our next step with the Backbone stuff is to look at the remaining .js files and do the same sort of conversion that we applied to the file in that change set.

I've updated the todo list in this issue to reflect that.