xous-core

xous-core copied to clipboard

Subscribers can disappear. Make this line (and similar ones) fail gracefully in case a caller has unsubscribed but the unsub call hasn't gone through yet: https://github.com/betrusted-io/xous-core/blob/b9dbabc198faac403b3f7f56a107f6c1da697d2b/services/net/src/connection_manager.rs#L412

bunnie

Need to ponder: Binary bloat in `Modals`

8

While adding bip39 dialog boxes to the system, I noted that a totally unrelated module that is not using BIP39 had its binary size increase. Before: https://ci.betrusted.io/view/Enabled/job/zz-analyze-bloat/76/artifact/reports/root-keys.txt ``` 3 .text...

bunnie

Reproducible builds and info leakage about the builder in binaries

2

Our build system is Rust's default build system, which by default includes things like the full path of the code (including the username) inside the binaries (for panic messages, strings,...

bunnie

There's a small bug in smoltcp that was fixed in https://github.com/smoltcp-rs/smoltcp/commit/8090469c2a1456b87a3e277e5b2f2e34e4f7555b Which prevents us from correctly reporting the state of nagle's algorithm. This issue helps anyone who encounters this to...

bunnie

Infinite loop on "Can't boot: No valid keys!"

7

https://github.com/betrusted-io/xous-core/blob/5c155587b65c3e1a1b5b12c2dfe501e1f1836dd6/loader/src/secboot.rs#L351 When the above loop is hit, how does one restart the phone?

msuiche

bcrypt is too slow

6

bcrypt with OWASP cost=10 parameter takes 5.7 seconds to run. 10 is the current recco; however, we are using cost=7 for a reasonable UX delay on password entry (0.8s). This...

bunnie

Build dependency sanitization (in particular build.rs files)

3

Xous relies on some dependencies from crates.io. Separate from the issue of reviewing the code itself, there is the issue that every crate has an opportunity to pull in a...

bunnie

1. Need to make sure `Subtle`/`.ct_eq()` is used in all the right places. 2. Strip out debug info that can leak hints about decryption/encryption success etc. This is basically a...

bunnie

Stage 1 loader - request for review

1

The early-stage loader, which runs before the kernel boots, is responsible for things like parsing configuration arguments. It's also responsible for keeping a [backup copy of the kernel arguments](https://github.com/betrusted-io/xous-core/blob/640ddb48e824b00de4a71ad8dc942f7e0e52cb22/loader/src/main.rs#L1134-L1141) and...

bunnie

Documenting transmutation of MemoryMessages into data structures

2

This issue is an attempt to document the hairy process of sharing memory between processes to aid with security audits. The core issue at stake is the passing of memory...

bunnie