xous-core icon indicating copy to clipboard operation
xous-core copied to clipboard

vaultbackup-rs not interacting with secret bases correctly

Open bunnie opened this issue 1 year ago • 1 comments

After using vaultbackup-rs backup, I got password entries copied to vaults they don't belong to.

I did a backup with vaultbackup-rs.

Process was:

I unlock base 1
I enable host readout on device
I do vaultbackup-rs backup password basename.json
I go to "Manage Bases" and lock the base
I go to the new base

It went well until I got to 3 bases with simlar (but not the same!) names.

I have bases like this:

secretbase, with password "this is not the real password" secretbase2, with password "this is not the real password secretbase2" secretbasex, with password "this is not the real password secretbasex"

When I exported secretbase2 and I checked the json, I noticed that it contains password entries from secretbase and secretbasex. (secretbase and secretbasex were NOT unlocked at the time) Secretbase2 had pretty much every entry from the other 2 bases.

Even worse, it was not only the json file -- secretbase2 on the precursor device had the duplicate entries from the other bases! So originally entries under secretbase now are under secretbase2 as well. Same name, same credentials, same password.

Even worse, when I checked secretbase, it had 3 random entries from secretbasex.

Even worse, these entries presisted even after shutting down and restarting the precursor.

bunnie avatar Sep 12 '23 04:09 bunnie

reported on xous v0.9.12-115-g6a2e3697

bunnie avatar Sep 12 '23 08:09 bunnie