Beto Dealmeida

Results 78 comments of Beto Dealmeida

Nice! I have a few questions and comments: 1. Should we have the DB/schema selectors above both the sidebar and the SQL editor, to reinforce the fact that the selection...

The clock house driver was not working correctly with SQL alchemy 1.4. They released a new version recently that fixed the problem (0.4.6, I think?), can you give that a...

> @betodealmeida I have updated the PR with suggested changes, could you please review it again? Looks like some of the tests are failing, can you take a look at...

I would love to see this, but there are few complications. The biggest one is that we need support from the SQL Alchemy dialects, and I'm not sure how many...

> I was planning to work on this, but of course I’d love help as I’ve never made a contribution to Superset. I was planning on doing a smaller task...

I think a good approach for this would be modifying `BaseEngineSpec.get_engine` to allow passing a catalog. The method would then pass it to `get_sqla_engine_with_context`, which would call a DB engine...

Actually, we would need the `apply_catalog_to_sqlalchemy_uri` to also pass `schema`: ```python @classmethod def apply_catalog_to_sqlalchemy_uri( cls, database: Database, catalog: Optional[str], schema: Optional[str], ) -> URL: try: connect_args = database.get_extra()["engine_params"]["connect_args"] except KeyError:...

Actually we already have a method to change the schema (`adjust_database_uri`), we should piggyback on that.

While working on an issue with schemas, I've done some foundational work for supporting catalogs: - https://github.com/apache/superset/pull/23356 - https://github.com/apache/superset/pull/23385 - https://github.com/apache/superset/pull/23401 Once we have that, I think we would still...

I'm going to work on (1) and (2) this week, then we can put the SIP to vote and you (or someone else) can work on the UI part, @JELGT2011.