config icon indicating copy to clipboard operation
config copied to clipboard

Add AXISFLYINGF745AIO config

Open ot0tot opened this issue 1 year ago • 5 comments

ot0tot avatar Sep 27 '24 13:09 ot0tot

status?

nerdCopter avatar Jan 10 '25 15:01 nerdCopter

I can't find the Discord channel where this was discussed, and do not remember the status. Does anyone know?

ot0tot avatar Jan 10 '25 19:01 ot0tot

If it helps here is the original dump of the bnf i got BTFL_cli_CINEONC35V3_20250109_180551_AXISFLYINGF745AIO.txt

Pancronos avatar Jan 15 '25 08:01 Pancronos

If it helps here is the original dump of the bnf i got BTFL_cli_CINEONC35V3_20250109_180551_AXISFLYINGF745AIO.txt

The manufacturer should not be shipping FCs with development firmware 🤦‍♂️

ot0tot avatar Jan 15 '25 21:01 ot0tot

If it helps here is the original dump of the bnf i got BTFL_cli_CINEONC35V3_20250109_180551_AXISFLYINGF745AIO.txt

The manufacturer should not be shipping FCs with development firmware 🤦‍♂️

you are right, also they advertise on their site the BNF with the AIO with Betaflight 4.6 and AM32, being a sponsor of BF i was convinced not to have a "surprise", instead it turned out there is no config, moreover Alka (AM32) said they never contacted him and the esc is flashed with an iflight version G071 that has problems, Alka advice was not to use it and do an upgrade of the iflight newer version. This of course is my first and last time i deal with axsisflying.

Pancronos avatar Jan 16 '25 22:01 Pancronos

Walkthrough

A new configuration header file for the AXISFLYINGF745AIO flight controller has been added. This file defines the hardware setup, including MCU type, board name, enabled sensors, peripheral assignments, pin mappings, timer channels, and default device settings, using macro definitions.

Changes

File(s) Change Summary
configs/AXISFLYINGF745AIO/config.h Added new configuration header with macro definitions for MCU, board, sensors, peripherals, pin assignments, timers, and default settings.

Poem

In the warren of wires, a new board hops in,
With macros and mappings, let flights now begin!
Pins and timers all set with care,
Sensors and LEDs, ready to share.
AXISFLYINGF745AIO, welcome to the sky—
With code and with carrots, we rabbits fly high!
🥕✈️

[!NOTE]

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Learn more here.


[!NOTE]

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings. Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between ff1f76f86161efcf3ba2d898b67e5a8acf08a925 and 9bda20f99f8de712bce811a6751288377bd9d5b6.

📒 Files selected for processing (1)
  • configs/AXISFLYINGF745AIO/config.h (1 hunks)
🔇 Additional comments (10)
configs/AXISFLYINGF745AIO/config.h (10)

1-20: License header looks consistent with Betaflight standards
The GPL‐v3 header matches other configuration files and includes the required directives.


22-28: Verify MCU target and board identifiers
Please confirm that the STM32F745 MCU and the 3–4 character BOARD_NAME/MANUFACTURER_ID values (AXISFLYINGF745AIO / AXFL) exactly match the datasheet and upstream naming conventions.


29-38: Double-check sensor macros
You’ve enabled both BMP280 and DPS310 barometers—confirm the board actually carries two baro devices. If only one is populated, remove the unused USE_BARO_* macro to avoid driver conflicts.


40-51: Confirm motor, servo and beeper pin assignments
The file defines 8 motor outputs along with two servos and an inverted beeper. Most AIO ESC boards are 4-motor; please verify this board genuinely exposes 8 PWM outputs and that PB5…PE14 and PB6/PB7 are correct hardware pin mappings.


52-63: Validate UART and ESC-sensor pin mapping
You’ve mapped UART1…UART6 TX/RX and then pointed ESCSERIAL_PIN at PA1 (which duplicates UART4_RX_PIN). This is likely intentional for ESC telemetry on UART4, but please confirm that there is no conflict with CLI/UART4 usage and that the ESC telemetry line is wired accordingly.


64-80: Review I²C and SPI bus pin allocations
SPI1…SPI4 and I2C1/I2C4 assignments cover the gyro, flash and OSD. Verify that none of these bus pins overlap with other peripherals (e.g. servo/PWM) and that SDA/SCL on PB8/PB9 and PD12/PD13 match the board silkscreen.


81-94: Inspect camera control, ADC inputs & GPIO-EX interrupts

  • CAMERA_CONTROL_PIN on PB3
  • ADC lines on PC1…PC5
  • PINIO1 on PC13
  • Two gyro EXTI/CS pairs (PD0/PA4, PD8/PB2)
    Confirm the board indeed has two independent gyro chips (or EXTI sources) before enabling dual EXTI lines, and ensure no pins conflict with the bootloader or user-button (e.g. PC13).

95-108: Verify the multi-line TIMER_PIN_MAPPING
Make sure each TIMER_PIN_MAP(idx, pin, timer, channel) matches the F7’s timer instance and channel. In particular, check that negative channel values (e.g. -1 for servos) align with your intended mode. A mismatch here will break PWM timing.


110-113: Check DMA and I²C instance options
ADC1_DMA_OPT = 0 and MAG_I2C_INSTANCE = I2CDEV_1, BARO_I2C_INSTANCE = I2CDEV_4 should correspond to your board’s DMA streams and bus numbering. Please verify these against the reference manual.


115-123: Confirm default device configurations
Defaults for blackbox, DSHOT bitbang, voltage/current meter sources, and PINIO1_BOX = 40 must reflect the physical wiring and Betaflight box assignments. Double-check the inverted beeper flag and PINIO mapping against flight-controller firmware expectations.

✨ Finishing Touches
  • [ ] 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar May 20 '25 22:05 coderabbitai[bot]

  • [x] passed schematics review?
  • [x] passed hardware samples testing?
  • [x] follows guidelines?
  • [x] follows connector standards?
  • [x] 8 motors issue resolved?
  • [x] flight tested

nerdCopter avatar May 22 '25 13:05 nerdCopter