blackbox-log-viewer
blackbox-log-viewer copied to clipboard
Add SupaflyFPV graphconfigs as default preset
Currently if you load blackbox viewer for the first time it has not workspaces to show. This adds basic workspace configuration from @SupaflyFPV as a default one.
Deploy Preview for origin-blackbox-logviewer ready!
Name | Link |
---|---|
Latest commit | ea554be1120daf9c5d200e1561e3fef65ce8f00f |
Latest deploy log | https://app.netlify.com/sites/origin-blackbox-logviewer/deploys/662cc3815d71eb00084a6e14 |
Deploy Preview | https://deploy-preview-734--origin-blackbox-logviewer.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
No data about Duplication
Thanks Tom! I think we can have a discussion with @ctzsnooze who uploaded his template here as what the best default would be....
In case my workspace is useful. i think for a normal user you should leave only the essentials:
- noise analysis tab, which includes: debug, unfiltered gyro, filtered gyro motors and RPMs
- PID analysis for each axis: P, I, D, setpiont, gyro, FF; PID sum, PID error; motors
This is the minimum set to analyse the log, it should be enough for ordinary users, advanced users will make their own workspace.
could we give to user a choice of several worspaces, like presets system?
could we give to user a choice of several worspaces, like presets system?
While it sounds nice, someone would need to build that 😜 and it doesn't sound like feature which can be added quickly.
could we give to user a choice of several worspaces, like presets system?
Why, if we can load any presets from file instead of default. The load and save workspace are working in Web version. This is very good!
Thanks Tom! I think we can have a discussion with @ctzsnooze who [uploaded his template here... as what the best default would be....
This preset is for min-max values control PR only. It will not have effect with current master branch version.
Why, if we can load any presets from file instead of default.
the problem is that user should find workspace somewhere. with multiple choice they could test different workspaces and choose the one which is better suits their needs. For example give users workspaces from ctzsnoose, UAVTech and Chriss Rosser as static examples, no need to integrate separate github repo for this
When we have a better default we can change it ... until then :)
@SupaflyFPV could you please put your workspace.json file here? The one used in this PR? Otherwise users who already loaded a workspace file, or saved their own settings, cannot easily review your 'default' workspace and can't provide feedback about it.