NWjs versioning depending on OS

[nerdCopter]

• NWjs versioning depending on OS; this is not preferred, but maybe necessary
• fixes https://github.com/betaflight/blackbox-log-viewer/issues/696
• proof-of-concept; DRAFT while in discussion/consideration
• this PR will re-test historical failure of GitHub action for NWjs 0.72.0
• win32 was not part of the issue, but added it as such is known to work.

[haslinghuis]

Seems to be still using 0.83 for osx:

[haslinghuis]

Yeah - working again - no 504

[nerdCopter]

• i don't like this solution; however, it seems to work.
• NW.js and ffmpeg may be un-syncronized with this.
• @ctzsnooze , can you test the executable-package created by this PR?

[github-actions[bot]]

Do you want to test this code? Here you have an automated build: Betaflight-Blackbox-Explorer-Linux Betaflight-Blackbox-Explorer-macOS Betaflight-Blackbox-Explorer-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

[sonarqubecloud[bot]]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[haslinghuis]

One issue might be with the ffmpeg libraries - not sure if we could retrieve the exact OSX version used - so to minimize impact of this change only applying to older versions.

[haslinghuis]

Maybe https://www.npmjs.com/package/get-osx-version

[github-actions[bot]]

Do you want to test this code? Here you have an automated build: Betaflight-Blackbox-Explorer-Linux Betaflight-Blackbox-Explorer-macOS Betaflight-Blackbox-Explorer-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

[nerdCopter]

i found some issue with any logic for when using gulpfile to retrieve the OS version (kernel). it is built on modern OSX (kernel), therefore will still choose modern NWjs, and thusly not be backward compatible. i tried os.release().startsWith('1') , where kernel is 1x.x.x for any OSX 10.x. kernel 2x.x.x for any OSX 11.x

[haslinghuis]

Can we have a macOSDeprecated strategy in the workflow matrix?

https://github.com/betaflight/blackbox-log-viewer/blob/a11ed062a2c9b851b8fcefaf511bd1309f5f11a6/.github/workflows/ci.yml#L16-L33

[haslinghuis]

But guess soon we won't be able to do so:

[nerdCopter]

the future is now :smile: :frowning_face:

[nerdCopter]

saw some NWjs issue tracker comments alluding to custom universal packages , but this is just more effort / maintenance :(

finding some more stuff. maybe [only] a newer nw-builder is required: https://github.com/nwutils/nw-builder/pull/783 basically this https://github.com/nwjs/nw.js/issues/8009 lead me down a rabbit-hole.

[ctzsnooze]

Solves the problem on my older Mac. So long as newer Macs are OK, I'm happy! Thank you!

[ikherty]

looks and works as usual, no problems noticed. MacBook Air M2 13.6" 512/16 GB, macOS Sonoma 14.3

Do you want to test this code? Here you have an automated build: Betaflight-Blackbox-Explorer-macOS WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

[haslinghuis]

@ikherty did you also test ffmpeg part?

[ikherty]

@ikherty did you also test ffmpeg part?

oh, sorry, I didn't try to play the video file. now I tried to open it, but the app closes immediately after selecting the file. I tried with different files, the behaviour is the same..

[nerdCopter]

thank you @ikherty . sorry @haslinghuis @ctzsnooze , i don't know a way to import different ffmpeg versions depending on NWjs version :frowning_face: .

maybe a BASH script at build-time :frowning_face: .

[github-actions[bot]]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

[github-actions[bot]]

Pull request closed automatically as inactive.