betaflight-configurator
betaflight-configurator copied to clipboard
Adds support for Airbot Theia OSD
Adds support for the new Airbot Theia OSD chip.
- Prevents incorrect display of "no OSD chip detected" message when using Theia OSD.
- Disables features requiring Max7456 font device when using Theia OSD.
Airbot will release a new OSD chip "Theia" - it is a replacement for the MAX IC.
Requires: #14391
Summary by CodeRabbit
-
New Features
- Improved device detection in the OSD interface to recognize Airbot Theia OSD devices when supported by firmware version 1.45 or higher.
-
Bug Fixes
- Refined visibility and enabled/disabled states for certain OSD UI elements based on the presence of Airbot Theia OSD devices, ensuring more accurate device status display.
Walkthrough
A boolean state property haveAirbotTheiaOsdDevice was added to OSD decoding, computed from flags and API version >= 1.47. osd.initialize UI logic was updated to incorporate this property when deciding visibility/disabled state of Max7456-related UI elements.
Changes
| Cohort / File(s) | Change Summary |
|---|---|
OSD tab changessrc/js/tabs/osd.js |
Added haveAirbotTheiaOsdDevice to OSD.data.state (computed as bit_check(d.flags, 7) && semver.gte(FC.CONFIG.apiVersion, API_VERSION_1_47)). Updated updateOsdView logic: .noOsdChipDetect now checks haveAirbotTheiaOsdDevice === false; .requires-max7456-font-device-detected disabled condition updated to `!isMax7456FontDeviceDetected |
Sequence Diagram(s)
sequenceDiagram
participant User
participant UI
participant OSD
participant FC as FlightController
User->>UI: Open OSD tab
UI->>OSD: initialize()
OSD->>FC: request OSD data
FC-->>OSD: flags + apiVersion
OSD->>OSD: decode flags/version
OSD->>OSD: set haveAirbotTheiaOsdDevice (flag7 && api>=1.47)
OSD->>UI: updateOsdView()
note right of UI #D3F2E8: UI decisions incorporate haveAirbotTheiaOsdDevice
UI->>UI: show/hide .noOsdChipDetect
UI->>UI: enable/disable .requires-max7456-font-device-detected
Estimated code review effort
๐ฏ 3 (Moderate) | โฑ๏ธ ~20 minutes
Suggested labels
RN: IMPROVEMENT
Suggested reviewers
- nerdCopter
- blckmn
- ledvinap
- VitroidFPV
[!TIP]
๐ Remote MCP (Model Context Protocol) integration is now available!
Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.
๐ Recent review details
Configuration used: .coderabbit.yaml Review profile: CHILL Plan: Pro
๐ก Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
๐ฅ Commits
Reviewing files that changed from the base of the PR and between 072ed7c6567c666f0670451cdb45781ca08ca8cd and d902ce3f23ef7fb79a012c643c3f6a0ec9a50c63.
๐ Files selected for processing (1)
src/js/tabs/osd.js(3 hunks)
๐ง Files skipped from review as they are similar to previous changes (1)
- src/js/tabs/osd.js
โจ Finishing Touches
- [ ] ๐ Generate Docstrings
๐งช Generate unit tests
- [ ] Create PR with unit tests
- [ ] Post copyable unit tests in a comment
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
๐ชง Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>, please review it.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. - PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
CodeRabbit Commands (Invoked using PR/Issue comments)
Type @coderabbitai help to get the list of available commands.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
Status, Documentation and Community
- Visit our Status Page to check the current availability of CodeRabbit.
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Preview URL: https://d902ce3f.betaflight-configurator.pages.dev
May I clarify: is this a new hardware chip, or is it a software-based OpenPixelOSD-style implementation?