Add OSD support for Angle of Attack

[haslinghuis]

• depends on https://github.com/betaflight/betaflight/pull/14244

This pull request introduces a new feature to display the "Angle of Attack" element in the On-Screen Display (OSD). The changes include updates to the localization messages, symbol definitions, and OSD field configurations.

Localization updates:

• locales/en/messages.json: Added messages and descriptions for the "Angle of Attack" element.

Symbol definitions:

• src/js/tabs/osd.js: Added SYM.ANGLE_OF_ATTACK with the symbol code 0x40.

OSD field configurations:

• src/js/tabs/osd.js: Added "ANGLE_OF_ATTACK" to the OSD.loadDisplayFields function with relevant properties like text, desc, defaultPosition, draw_order, and preview.
• src/js/tabs/osd.js: Included F.ANGLE_OF_ATTACK in the OSD.chooseFields function to ensure it is selectable.

Summary by CodeRabbit

• New Features
  • Added a new "Angle of attack" element to the On Screen Display (OSD) for compatible firmware versions (API 1.47 and above).
  • Updated English language support to include text and description for the new "Angle of attack" OSD element.

[netlify[bot]]

✅ Deploy Preview for origin-betaflight-app ready!

Name	Link
🔨 Latest commit	74e8ae8c028b8ad746bd2d599db4772327cc3c0f
🔍 Latest deploy log	https://app.netlify.com/sites/origin-betaflight-app/deploys/67ce0be5449a24000840ddb3
😎 Deploy Preview	https://deploy-preview-4339.dev.app.betaflight.com
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[demvlad]

This is great! I've just thought about delete (//comment) my osd blink mode code to go it in separate PRs. I've not seen osd indication during last test my PR, due of some mistake probably. Will test with this PR together next time.

[sonarqubecloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai[bot]]

Walkthrough

The changes introduce a new "Angle of attack" element to the On Screen Display (OSD) system. This includes adding English localization strings for the new element and its description, defining a new symbol constant for "Angle of attack," and updating the display fields to include this element for firmware versions 1.47 and above. The new display field is fully integrated with properties for name, text, description, position, draw order, and preview formatting.

Changes

File(s)	Change Summary
locales/en/messages.json	Added two new localization entries: "osdTextElementAngleOfAttack" and "osdDescElementAngleOfAttack".
src/js/tabs/osd.js	Added ANGLE_OF_ATTACK symbol constant, defined new display field for "Angle of attack", and updated field selection logic for firmware API 1.47+.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant OSD_Module
    participant Firmware

    User->>OSD_Module: Load OSD configuration
    OSD_Module->>Firmware: Query firmware API version
    Firmware-->>OSD_Module: Return API version (>= 1.47)
    OSD_Module->>OSD_Module: Add ANGLE_OF_ATTACK to display fields
    OSD_Module->>User: Render OSD with Angle of attack element

Poem

In the fields where numbers stack,
A new angle joins the pack!
"Angle of attack" now takes its place,
With symbols, text, and a previewed face.
OSD grows, the screens delight—
More data for every flight!
🐰✨

✨ Finishing Touches

• [ ] 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sugaarK]

I've lined up some air speed sensors with another wing fc.. AoA sensors are a small vane that measures the angle of the airflow past it.. not something you can estimate using the current sensor package as its relative airflow with out reference to the attitude

[demvlad]

AoA sensors are a small vane that measures the angle of the airflow past it.. not something you can estimate using the current sensor package as its relative airflow with out reference to the attitude

@sugaarK Thank's for review. Yes, I understand that this is a 'paper' algorithms, what has limited range and accuracy in really. It has calibrating problem too. We need real sensors for AoA and airspeed. I see Matek and similar airspeed sensors. But I've never seen AoA sensors for RC. I continue airplane research in this PR: https://github.com/betaflight/betaflight/pull/14350/files/15bd4634eeefac29f94f903b5b895c4ec749964e..ffff2776e0286361349af38168c99f8f0894d332

I will try to use lift force coefficient instead of AoA for algorithms. It works, but I need properly air speed to estimate it too.

[sugaarK]

AoA sensors are a small vane that measures the angle of the airflow past it.. not something you can estimate using the current sensor package as its relative airflow with out reference to the attitude

@sugaarK Thank's for review. Yes, I understand that this is a 'paper' algorithms, what has limited range and accuracy in really. It has calibrating problem too. We need real sensors for AoA and airspeed. I see Matek and similar airspeed sensors. But I've never seen AoA sensors for RC. I continue airplane research in this PR: https://github.com/betaflight/betaflight/pull/14350/files/15bd4634eeefac29f94f903b5b895c4ec749964e..ffff2776e0286361349af38168c99f8f0894d332

I will try to use lift force coefficient instead of AoA for algorithms. It works, but I need properly air speed to estimate it too.

it would be very easy to make one.. its an rotational angle sensor with a vane that you could print

[demvlad]

it would be very easy to make one.. its an rotational angle sensor with a vane that you could print

Yes, it's work is easy. But it needs a good hands to build it. :)

[sugaarK]

it would be very easy to make one.. its an rotational angle sensor with a vane that you could print

Yes, it's work is easy. But it needs a good hands to build it. :)

PCBway lols

[sugaarK]

it would be very easy to make one.. its an rotational angle sensor with a vane that you could print

Yes, it's work is easy. But it needs a good hands to build it. :)

as6500 encoder printed vane and housing!!! job done

[demvlad]

as6500 encoder printed vane and housing!!! job done

Yes, this is good! Do you know some small rotation sensor?

[github-actions[bot]]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

[demvlad]

The airplanes flight control system research continues here: https://github.com/betaflight/betaflight/pull/14350#issuecomment-3577337294

This PR is closed.

[sugaarK]

as6500 encoder printed vane and housing!!! job done

Yes, this is good! Do you know some small rotation sensor?

https://www.sciosense.com/wp-content/uploads/2023/12/AS6500-Datasheet.pdf

https://38-3d.co.uk/blogs/blog/how-to-use-the-as5600-magnetic-rotary-encoder-with-arduino?srsltid=AfmBOorL8yQcxS2NVCnLLifGDI0e60lDKOy7i7YBdaxaNIiO2ewQj2Rw