betaflight-configurator icon indicating copy to clipboard operation
betaflight-configurator copied to clipboard

add ToolTip for AirMode

Open nerdCopter opened this issue 1 year ago • 6 comments

  • https://discord.com/channels/868013470023548938/1019022739044057128/1293513438156296222
  • modifies and re-uses auxiliaryHelpMode_AIRMODE
  • whether it is accurate verbiage or not, this PR achieves the OP's desired outcome which is to duplicate the tooltip from aux-modes to the configuration tab. (https://discord.com/channels/868013470023548938/1019022739044057128/1293562306525139055)
  • i''l leave this as draft until others chime in. feel free to modify. i'm open to verbiage changes.

image image

nerdCopter avatar Oct 09 '24 13:10 nerdCopter

Deploy Preview for origin-betaflight-app ready!

Name Link
Latest commit d8a7b7d209ed0edb16b90b66f1d556c2d5c68e67
Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/671fae1f82c8490008372670
Deploy Preview https://deploy-preview-4206.dev.app.betaflight.com
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 09 '24 13:10 netlify[bot]

We have this word salad:

image

See auxiliaryHelpMode_AIRMODE

haslinghuis avatar Oct 09 '24 15:10 haslinghuis

so many words to confuse the pilot :laughing: and use of "you" as the pilot. oh i see that came from the .com, how about i link the .com? EDIT: oh, it came from auxiliaryHelpMode_AIRMODE as well as you pointed out.

nerdCopter avatar Oct 09 '24 15:10 nerdCopter

Perhaps:

In standard mode, when roll, pitch, and yaw calculations saturate a motor, all motors are equally reduced. If a motor goes below minimum, it gets clipped off. For example, with throttle just above minimum and a quick roll is attempted, two motors can't go any lower, resulting in half the power (half of the PID gain). If inputs demand more than a 100% difference between high and low motors, the low motors get clipped, causing an imbalance by unevenly reducing the gain.

haslinghuis avatar Oct 09 '24 15:10 haslinghuis

  • i've taken it out of draft.
  • personally i don't like the wordiness -- I'd have preferred something much simpler such as Normalizes motor output at low throttle to allow maintaining of the craft., but this is not my call.

nerdCopter avatar Oct 22 '24 13:10 nerdCopter

Such a big pop-over element might cause UX and UI style issues, I think shortening it is more beneficial than having it be fully detailed. If links work in tooltip boxes, might be a good idea to link to the wiki for the full explanation

VitroidFPV avatar Oct 25 '24 19:10 VitroidFPV

thanks @VitroidFPV , I really agree, i think i'll revert to short text (+link) next work-week unless there are more comments to the contrary.

nerdCopter avatar Oct 25 '24 20:10 nerdCopter

@VitroidFPV @KarateBrot @mituritsyn
re-used the first sentence, which allude "pid at min throttle" and linked the .com thoughts?

nerdCopter avatar Oct 27 '24 00:10 nerdCopter

thanks @VitroidFPV , I really agree, i think i'll revert to short text (+link) next work-week unless there are more comments to the contrary.

I personnaly vote for @ctzsnooze formulation: Airmode' == the mixer behaviour where 'throttle is automatically raised, to maintain authority at low throttle. Just need to rephrase a bit

mituritsyn avatar Oct 27 '24 08:10 mituritsyn

:( i was still editing, but my internet provider is going hay-wire. i was not ready for merge. i did not like the word drone as locales/en/messages.json only uses it one other instance. and also wanted to account for Mike's preference.

nerdCopter avatar Oct 28 '24 15:10 nerdCopter

Apologies assumed this was ready after 24 hours cool of period.

haslinghuis avatar Oct 28 '24 15:10 haslinghuis

i try to stay offline on weekends. saw the comments this morning, but internet intermittent.

diff --git a/locales/en/messages.json b/locales/en/messages.json
index 94199765..d86ce3c2 100755
--- a/locales/en/messages.json
+++ b/locales/en/messages.json
@@ -1324,7 +1324,9 @@
         "message": "Permanently enable Airmode"
     },
     "featureAIRMODETip": {
-        "message": "$t(auxiliaryHelpMode_AIRMODE.message)"
+        "message": "$t(auxiliaryHelpMode_AIRMODE.message)",
+        "description": "Don't translate!!!"
+
     },
     "featureRX_SPI": {
         "message": "SPI Rx (e.g. built-in Rx)"
@@ -2411,7 +2413,7 @@
         "description": "Help text to ANTIGRAVITY mode"
     },
     "auxiliaryHelpMode_AIRMODE": {
-        "message": "AirMode allows for maintaining PID control at low throttle. For more information please see <a href=\"https://betaflight.com/docs/development/modes#airmode\" target=\"_blank\" rel=\"noopener noreferrer\">AirMode</a> on Betaflight.com.",
+        "message": "AirMode is a motor mixer behavior that automatically raises throttle during low-throttle input in order to maintain the craft's authority. For more information please see <a href=\"https://betaflight.com/docs/development/modes#airmode\" target=\"_blank\" rel=\"noopener noreferrer\">AirMode</a> on Betaflight.com.",
         "description": "Help text to AIRMODE mode"
     },
     "auxiliaryHelpMode_BEEPER": {

either i can PR again, or just let it be.

nerdCopter avatar Oct 28 '24 15:10 nerdCopter