betaflight-configurator icon indicating copy to clipboard operation
betaflight-configurator copied to clipboard

Added Custom Defines Dropdown

Open YarosMallorca opened this issue 1 year ago • 5 comments

Screenshot 2024-07-06 at 22 23 22

YarosMallorca avatar Jul 06 '24 20:07 YarosMallorca

Deploy Preview for origin-betaflight-app ready!

Name Link
Latest commit 561e6609a4e10c0c913670c473bf4206747a89f6
Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/6689b2bd50957500087209ed
Deploy Preview https://deploy-preview-4091.dev.app.betaflight.com
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jul 06 '24 20:07 netlify[bot]

We probably need discussion about filtering the list

  • some are already included by default
  • some are exposed using other options
  • would like using OSD_SD and OSD_HD to be exclusive

haslinghuis avatar Jul 06 '24 20:07 haslinghuis

Yes, I also thought about this. I'll convert this to a draft for now.

YarosMallorca avatar Jul 06 '24 20:07 YarosMallorca

Was trying to keep up with documentation. Made some list here: https://betaflight.com/docs/development/API/Cloud-Build-API#custom-defines

See also: https://betaflight.com/docs/development/manufacturer/manufacturer-design-guidelines#42-definitions-for-targets

haslinghuis avatar Jul 06 '24 20:07 haslinghuis

One thing I forgot. We also have this usage: https://github.com/betaflight/betaflight/pull/13346

haslinghuis avatar Jul 06 '24 20:07 haslinghuis

I think maybe is better for this, that the cloud can give this information, to not have to maintain the list, I'm pretty sure we will forget to add/remove some of them in the future. I don't know if this is feasible. The easiest way maybe is that the cloud can execute some command to "search" for defines at some folders in the source, and publish it as web service. This list is only used with cloud building, so the correct will be to let the cloud maintain it.

McGiverGim avatar Nov 04 '24 09:11 McGiverGim

agree with @McGiverGim . there are too many to track and often change between version. furthermore, some USE_ don't work as a custom define.

nerdCopter avatar Nov 04 '24 13:11 nerdCopter

Alright, got it. Thanks for your comments!

YarosMallorca avatar Nov 04 '24 18:11 YarosMallorca