betaflight-configurator icon indicating copy to clipboard operation
betaflight-configurator copied to clipboard

Add tests again to the Github Actions

Open McGiverGim opened this issue 1 year ago • 3 comments

This adds the Github Actions to the PWA (master) version of the Configurator again. In this way we pass the (few) tests that we have and, principally, the lint.

The problem is that tests don't pass right now. The port_handler.js access the serialShim() and seems that the test engine doesn't detect this function. If we fix that the webSerial.js will not find the navigator.serial.

I suppose we need some kind of mock but I'm not too sure how to do it. @Benky I know it has passed a lot of time from this, but maybe you have some time to make this working again? Any other is able to fix this?

McGiverGim avatar May 19 '24 07:05 McGiverGim

Deploy Preview for origin-betaflight-app ready!

Name Link
Latest commit 2d04e3552637a105fc75e35f806d2e716d64ec77
Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/6649a58d864e1a0008335746
Deploy Preview https://deploy-preview-3973.dev.app.betaflight.com
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 19 '24 07:05 netlify[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
8.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar May 19 '24 07:05 sonarqubecloud[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

github-actions[bot] avatar Jun 19 '24 04:06 github-actions[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

github-actions[bot] avatar Jul 20 '24 04:07 github-actions[bot]

Pull request closed automatically as inactive.

github-actions[bot] avatar Jul 28 '24 04:07 github-actions[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

github-actions[bot] avatar Aug 28 '24 04:08 github-actions[bot]

Pull request closed automatically as inactive.

github-actions[bot] avatar Sep 04 '24 04:09 github-actions[bot]