betaflight-configurator icon indicating copy to clipboard operation
betaflight-configurator copied to clipboard

Add support for using MSP build options

Open haslinghuis opened this issue 1 year ago • 22 comments

  • Details and depends on: https://github.com/betaflight/betaflight/pull/13333
  • Reduces cloud build API requests
  • Works for local builds and offline
  • Firmware flasher keeps using cloud build API request for easy transition

haslinghuis avatar Feb 01 '24 00:02 haslinghuis

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

github-actions[bot] avatar Feb 01 '24 00:02 github-actions[bot]

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

github-actions[bot] avatar Feb 01 '24 00:02 github-actions[bot]

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

github-actions[bot] avatar Feb 01 '24 01:02 github-actions[bot]

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

github-actions[bot] avatar Feb 01 '24 18:02 github-actions[bot]

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

github-actions[bot] avatar Feb 01 '24 19:02 github-actions[bot]

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

github-actions[bot] avatar Feb 01 '24 19:02 github-actions[bot]

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

github-actions[bot] avatar Feb 01 '24 20:02 github-actions[bot]

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

github-actions[bot] avatar Feb 01 '24 20:02 github-actions[bot]

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

github-actions[bot] avatar Feb 01 '24 21:02 github-actions[bot]

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

github-actions[bot] avatar Feb 01 '24 22:02 github-actions[bot]

is this to wait for 4.6? or should it be tested/merged prior so that 4.6 will work out of the box?

nerdCopter avatar Feb 02 '24 14:02 nerdCopter

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

github-actions[bot] avatar Feb 02 '24 17:02 github-actions[bot]

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

github-actions[bot] avatar Feb 02 '24 17:02 github-actions[bot]

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Feb 02 '24 18:02 sonarqubecloud[bot]

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

github-actions[bot] avatar Feb 02 '24 18:02 github-actions[bot]

Seems to the firmware in #13333 still send API 1.46, when this PR can't work (1.47)

HThuren avatar Feb 04 '24 19:02 HThuren

In serial_backend it uses 1.46 for testing.

haslinghuis avatar Feb 04 '24 19:02 haslinghuis

@blckmn has to decide inclusion in current or next release.

haslinghuis avatar Feb 04 '24 19:02 haslinghuis

right, but I tried to test this (?) image

HThuren avatar Feb 04 '24 19:02 HThuren

Firmware flasher does not use it right now as I wanted to make transition easy

haslinghuis avatar Feb 04 '24 19:02 haslinghuis

@blckmn has to decide inclusion in current or next release.

Next release. We have to start focusing on bug fixes only during RC phases.

blckmn avatar Feb 04 '24 19:02 blckmn

... and we change https://github.com/betaflight/betaflight/pull/13333 to API 1.47

HThuren avatar Feb 04 '24 22:02 HThuren

test result of 180d141b

# version
# Betaflight / STM32F405 (S405) 4.5.0 Apr 18 2024 / 13:15:29 (71776a852) MSP API: 1.46
# config rev: 7556c8e
# board: manufacturer_id: FOXE, board_name: FOXEERF405
2024-04-18 @15:35:22 -- Board: FOXE/FOXEERF405(STM32F405), version: 0
2024-04-18 @15:35:22 -- Build Key: 5c236ba9739999abaf794d4215fda4a5

image image image

off subject: image

nerdCopter avatar Apr 18 '24 20:04 nerdCopter

Deploy Preview for origin-betaflight-app ready!

Name Link
Latest commit 44f42c3edf5ec638fee8a789b97ade31539efdc4
Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/6621a7dbd71d250008d15dda
Deploy Preview https://deploy-preview-3780--origin-betaflight-app.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 18 '24 22:04 netlify[bot]

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-Windows Betaflight-Configurator-macOS WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

github-actions[bot] avatar Apr 18 '24 22:04 github-actions[bot]

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-Windows Betaflight-Configurator-macOS WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

github-actions[bot] avatar Apr 18 '24 23:04 github-actions[bot]

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

github-actions[bot] avatar Apr 18 '24 23:04 github-actions[bot]

44f42c3e -- retested with local build, no key:

make FOXEERF405 EXTRA_FLAGS="-D'RELEASE_NAME=4.5.0-dev' -DCLOUD_BUILD -DUSE_CAMERA_CONTROL -DUSE_DSHOT -DUSE_EMFAT_AUTORUN -DUSE_EMFAT_ICON -DUSE_EMFAT_TOOLS -DUSE_GPS -DUSE_GPS_PLUS_CODES -DUSE_LED_STRIP -DUSE_OSD -DUSE_OSD_SD -DUSE_PINIO -DUSE_SERIALRX -DUSE_SERIALRX_CRSF -DUSE_TELEMETRY -DUSE_TELEMETRY_CRSF -DUSE_VTX"

did not produce auto-detect results i expected (no MSP?): image

but did produce this as Discord comments alluded: image

nerdCopter avatar Apr 19 '24 12:04 nerdCopter

Currently MSP build options is supported for 4.6 firmware. See second commit. Firmware part was merged for 4.5. Should we change it to 4.5 here too?

haslinghuis avatar Apr 19 '24 13:04 haslinghuis