betaflight-configurator
betaflight-configurator copied to clipboard
betaflight
Hide GPS Signal Strength if GPS is not active
Only show GPS Signal Strength when GPS is active.
Currently when having SatInfo and powering off the GPS configurator only shows last frozen state.
Resetting data won't show values - we can show an informational message like:
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
AUTOMERGE: (FAIL)
- github identifies PR as mergeable -> FAIL
- assigned to a milestone -> PASS
- cooling off period lapsed -> PASS
- commit count less or equal to three -> PASS
-
Don't mergelabel NOT found -> PASS - at least one
RN:label found -> PASS -
Testedlabel found -> FAIL - assigned to an approver -> PASS
- approver count at least three -> FAIL
Would it make more sense to re-initialize the values upon disconnect or GPS-not-powered state?
Quality Gate passed
Kudos, no new issues were introduced!
0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
See analysis details on SonarCloud
![sonarqubecloud[bot] avatar](https://avatars.githubusercontent.com/in/12526?v=4 "Published by a pub.dev verified publisher"){kind=small}
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
Do not want to make it to complicated. Thinking about it perhaps we should have a second message - but requires keeping state.
- At startup when no signal data has been received as GNSS has not been detected yet we show the message above.
- When loosing signal after being detected we show a message like
The GNSS unit is no longer recognized.
This should probably be a 4.6 new feature. It is an improvement but could introduce unexpected issues, and will require testing that would delay 4.5.
Hi Mark... checking this now - does it need rebasing? Seems to work, when I test it, and the message is useful.
Perhaps the text could say:
Connecting...
The GPS icon lights up when Betaflight is connected to a GPS module. This usually takes a couple of seconds.<br>
It will be red at first, then change to yellow when it gets a 3D fix.<br>
If the GPS icon does not light up, check your wiring and configuration, and confirm that the GPS module is receiving power.<br>
The CLI "status" command provides more information about the state of the GPS connection.
That last line is optional and perhaps unnecessary, whatever you think.
Deploy Preview for origin-betaflight-configurator ready!
| Name | Link |
|---|---|
| Latest commit | b6f6b79b7567afff79f1b83cd9ab9c443eeba9a3 |
| Latest deploy log | https://app.netlify.com/sites/origin-betaflight-configurator/deploys/6616852dbc6f7b0008e10521 |
| Deploy Preview | https://deploy-preview-3705--origin-betaflight-configurator.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-Windows Betaflight-Configurator-macOS WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-Windows Betaflight-Configurator-macOS WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-Windows Betaflight-Configurator-macOS WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
Just checking the PR again...
There is a bit of pale grey space under the 'yellow' of the 'Connecting...' note - maybe that can be removed?
Also, I wonder if some tiny simplifications, and wider line spacing, may improve readability:
The GPS icon lights up only when the connection to the GPS module is confirmed.<br>
<br>
It will be red at first, changing to yellow when the 3D fix is attained.<br>
<br>
If the GPS icon does not light up, check your wiring and configuration, and confirm that the GPS module is receiving power.<br>
<br>
The CLI 'status' command provides more information about the state of the GPS connection.
Quality Gate passed
Issues
1 New issue
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
See analysis details on SonarCloud
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Linux Betaflight-Configurator-Android Betaflight-Configurator-Windows Betaflight-Configurator-macOS WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!