betaflight-configurator Update NWjs to 0.83

Check to fix virus issues reported with current build on Windows. Previous we were not able to go up due to icon issue which seems solved now.

Dec 26 '23 01:12 haslinghuis

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

Dec 26 '23 01:12 github-actions[bot]

AUTOMERGE: (FAIL)

github identifies PR as mergeable -> FAIL
assigned to a milestone -> PASS
cooling off period lapsed -> PASS
commit count less or equal to three -> PASS
Don't merge label NOT found -> PASS
at least one RN: label found -> PASS
Tested label found -> FAIL
assigned to an approver -> PASS
approver count at least three -> FAIL

Dec 26 '23 03:12 blckmn

0.83 give same issue with worm in resourcer.exe, Also at my pc found more connections (my headset) AND the installer exe now has the right BF icon. BUT the installed application does not have the Icon (??)

The worm issue when you build the debug and release application, not when you run the bf installer, nor the bf configurator after installation.

Dec 26 '23 12:12 HThuren

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Dec 31 '23 19:12 sonarqubecloud[bot]

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

Dec 31 '23 19:12 github-actions[bot]

NWjs developers often acknowledge existence of false-positive virus-checks simply as a by-product of exe generation. :( Unsure about the icon issue. Maybe windows icon cache could be cleared as a troubleshooting step.

Dec 31 '23 21:12 nerdCopter

NWjs developers often acknowledge existence of false-positive virus-checks simply as a by-product of exe generation. :( Unsure about the icon issue. Maybe windows icon cache could be cleared as a troubleshooting step.

Windows defender discover the signature from Win32/AutoRun!pz when resourcer.exe (who do the icon change) start. Defender stop resourcer.exe, report and you have no icon shift. Since resourcer.exe are from 2009, we might can compile a new one with today runtime libs, but then we need the source and the references regarding resourcer.exe are dead. I have wrote to Felicien, if he by luck have the source, but no responce yet. Otherwise we need a new way to change the icon, I suppose deals with windows, mac and linux.

Jan 01 '24 10:01 HThuren

Did someone try 0.85?