betaflight-configurator icon indicating copy to clipboard operation
betaflight-configurator copied to clipboard

Mode Tab have Modes grouped in category and selections depend on Cloud build options

Open HThuren opened this issue 2 years ago • 69 comments

This PR categorize Modes in groups to be controlled by Build Options or all modes if local build (ie. Build Option are empty). Your selection are saved between sessions.

Categorys give more easy view of functionality when configure modes, ie. select Flightmode only to check setup in one list without need to schroll.

Categorys are Cloud build (fx USE_SERVO are not defined in firmware) or local build: (SERVO are shown as example, will be hided in final design) image

Examples of selections, where also unused mode still works: image

HThuren avatar Sep 17 '23 10:09 HThuren

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

github-actions[bot] avatar Sep 17 '23 10:09 github-actions[bot]

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> FAIL
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> FAIL
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

blckmn avatar Sep 17 '23 12:09 blckmn

personally i don't see a need for this, but mine is just an opinion.

nerdCopter avatar Sep 18 '23 13:09 nerdCopter

personally i don't see a need for this, but mine is just an opinion.

On the other side, it won't harm and help new users (like me :-)) to identify and understand flightmodes and give the overview for excatly them.

HThuren avatar Sep 18 '23 16:09 HThuren

something wrong with "hide unused modes" -- expecting it to hide everything not set. https://youtu.be/mc_8-tA_eS4

nerdCopter avatar Sep 18 '23 18:09 nerdCopter

something wrong with "hide unused modes" -- expecting it to hide everything not set. https://youtu.be/mc_8-tA_eS4

I havn't tried with everything empty, will do See it, good catch !

HThuren avatar Sep 18 '23 19:09 HThuren

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Oct 10 '23 04:10 sonarqubecloud[bot]

... took long time to catch, just to discover start at index 1 solved the issue found by @nerdCopter

HThuren avatar Oct 10 '23 04:10 HThuren

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

github-actions[bot] avatar Oct 10 '23 05:10 github-actions[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

github-actions[bot] avatar Nov 10 '23 04:11 github-actions[bot]

Found any bugs here ?

HThuren avatar Nov 10 '23 13:11 HThuren

Found any bugs here ?

yes :( https://youtu.be/yybuWCdXYfc

nerdCopter avatar Nov 10 '23 15:11 nerdCopter

Damn :-(

HThuren avatar Nov 10 '23 16:11 HThuren

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

github-actions[bot] avatar Dec 11 '23 23:12 github-actions[bot]

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

github-actions[bot] avatar Dec 11 '23 23:12 github-actions[bot]

Have no idea yet. But think we should decide on how it's going to look and work as I have already suggested using groups for certain modes we intent adding after release. But that's a bit hard now if they don't exist yet :smiley:

haslinghuis avatar Dec 11 '23 23:12 haslinghuis

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

github-actions[bot] avatar Dec 12 '23 07:12 github-actions[bot]

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

github-actions[bot] avatar Dec 12 '23 23:12 github-actions[bot]

hi @haslinghuis, I can't see this change request ? image

HThuren avatar Dec 13 '23 16:12 HThuren

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

github-actions[bot] avatar Dec 13 '23 21:12 github-actions[bot]

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

github-actions[bot] avatar Dec 15 '23 01:12 github-actions[bot]

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

github-actions[bot] avatar Dec 17 '23 20:12 github-actions[bot]

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

github-actions[bot] avatar Dec 21 '23 22:12 github-actions[bot]

Now ready to review, last CSS issue solved

HThuren avatar Dec 21 '23 23:12 HThuren

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

github-actions[bot] avatar Dec 23 '23 09:12 github-actions[bot]

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Dec 26 '23 12:12 sonarqubecloud[bot]

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

github-actions[bot] avatar Dec 26 '23 12:12 github-actions[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

github-actions[bot] avatar Jan 26 '24 04:01 github-actions[bot]

Pull request closed automatically as inactive.

github-actions[bot] avatar Feb 02 '24 04:02 github-actions[bot]

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

github-actions[bot] avatar Feb 02 '24 06:02 github-actions[bot]