betaflight-configurator
betaflight-configurator copied to clipboard
Mode Tab have Modes grouped in category and selections depend on Cloud build options
This PR categorize Modes in groups to be controlled by Build Options or all modes if local build (ie. Build Option are empty). Your selection are saved between sessions.
Categorys give more easy view of functionality when configure modes, ie. select Flightmode only to check setup in one list without need to schroll.
Categorys are Cloud build (fx USE_SERVO are not defined in firmware) or local build:
(SERVO are shown as example, will be hided in final design)
Examples of selections, where also unused mode still works:
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
AUTOMERGE: (FAIL)
- github identifies PR as mergeable -> FAIL
- assigned to a milestone -> FAIL
- cooling off period lapsed -> PASS
- commit count less or equal to three -> FAIL
Don't mergelabel NOT found -> PASS- at least one
RN:label found -> PASS Testedlabel found -> FAIL- assigned to an approver -> FAIL
- approver count at least three -> FAIL
personally i don't see a need for this, but mine is just an opinion.
personally i don't see a need for this, but mine is just an opinion.
On the other side, it won't harm and help new users (like me :-)) to identify and understand flightmodes and give the overview for excatly them.
something wrong with "hide unused modes" -- expecting it to hide everything not set. https://youtu.be/mc_8-tA_eS4
something wrong with "hide unused modes" -- expecting it to hide everything not set. https://youtu.be/mc_8-tA_eS4
I havn't tried with everything empty, will do See it, good catch !
Kudos, SonarCloud Quality Gate passed! 
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
... took long time to catch, just to discover start at index 1 solved the issue found by @nerdCopter
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.
Found any bugs here ?
Found any bugs here ?
yes :( https://youtu.be/yybuWCdXYfc
Damn :-(
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
Have no idea yet. But think we should decide on how it's going to look and work as I have already suggested using groups for certain modes we intent adding after release. But that's a bit hard now if they don't exist yet :smiley:
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
hi @haslinghuis, I can't see this change request ?
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
Now ready to review, last CSS issue solved
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
Quality Gate passed
Kudos, no new issues were introduced!
0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.
Pull request closed automatically as inactive.
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!