betaflight-configurator icon indicating copy to clipboard operation
betaflight-configurator copied to clipboard

Adding Configurator support for new OSD feature Camera Angle Reference

Open MedlinDrone opened this issue 1 year ago • 19 comments

Camera Angle Reference OSD Feature

Requires: https://github.com/betaflight/betaflight/pull/13070

This is my first pull request so be gentle. Will be submitting the Betaflight pull request directly after submitting configurator and will reference this pull request in the other.

This is an OSD visual reference for current camera angle intended to be used with a single axis tilt gimbal, like those shown on medlindrone.com

This is currently configured via CLI, will add a GUI for it in the future.

There are five new cli parameters: -osd_car_pos (osd element position) -osd_car_channel (channel controlling the gimbal/apl) -osd_car_scale (scale for adjusting vertical scale / sensitivity) -osd_car_width (width for adjusting witdh between dots) -osd_car_dots (number of dots on each side)

Discussion https://github.com/betaflight/betaflight/discussions/12438

MedlinDrone avatar Sep 07 '23 19:09 MedlinDrone

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 07 '23 19:09 sonarqubecloud[bot]

https://github.com/betaflight/betaflight-configurator/assets/89054758/0ca39879-0361-43b2-abe8-f3852c171af3

MedlinDrone avatar Sep 07 '23 19:09 MedlinDrone

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

github-actions[bot] avatar Sep 07 '23 19:09 github-actions[bot]

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> FAIL
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

blckmn avatar Sep 07 '23 21:09 blckmn

Depends on https://github.com/betaflight/betaflight/pull/13070

MedlinDrone avatar Sep 07 '23 23:09 MedlinDrone

What's the difference between this new 'artificial horizon' type indicator, and the old one?

ctzsnooze avatar Sep 16 '23 01:09 ctzsnooze

What's the difference between this new 'artificial horizon' type indicator, and the old one?

i believe it refers to camera tilt/angle of a single axis tilt gimbal.

nerdCopter avatar Sep 16 '23 19:09 nerdCopter

@MedlinDrone, you don't have to change language other than en since Crowin will add to the other languages.

HThuren avatar Sep 17 '23 15:09 HThuren

What's the difference between this new 'artificial horizon' type indicator, and the old one?

@ctzsnooze what @nerdCopter is correct, when flying with a single-axis tilt gimbal (like those on medlindrone.com) this shows you an artificial propeller line/cockpit so that you know what camera angle you are at.

MedlinDrone avatar Sep 17 '23 17:09 MedlinDrone

@MedlinDrone, you don't have to change language other than en since Crowin will add to the other languages.

@HThuren Thanks for letting me know, I added the entries into the various messages files in English just to make sure it didn't break anything, is that the correct way to do it or should I not touch the other languages message files?

MedlinDrone avatar Sep 17 '23 17:09 MedlinDrone

@MedlinDrone, you don't have to change language other than en since Crowin will add to the other languages.

@HThuren Thanks for letting me know, I added the entries into the various messages files in English just to make sure it didn't break anything, is that the correct way to do it or should I not touch the other languages message files?

Hi @MedlinDrone, no, you just add to the en file, Crowdin do the rest.

HThuren avatar Sep 17 '23 17:09 HThuren

@MedlinDrone you can cover up by doing a "git restore xx" where xx are full path to the language files other than "en"

HThuren avatar Oct 10 '23 05:10 HThuren

@HThuren I updated the pull request, now it only includes the English messages file

MedlinDrone avatar Oct 24 '23 14:10 MedlinDrone

CAR 'Camera Angle Reference' CLI Values.

-CAR Channel controlling servo/gimbal osd_car_channel = 7 Allowed range: 1 - 18 Default value: 7

-CAR Scale for adjusting vertical scale / sesitivity osd_car_scale = 13 Allowed range: -22 - 22 Default value: 13

-CAR Dots for adjusting number of dots on each side osd_car_dots = 3 Allowed range: 1 - 20 Default value: 7

-CAR Width for adjusting witdh between dots osd_car_width = 16 Allowed range: 5 - 46 Default value: 18

CAR Sidebar Values.

-CAR Sidebar Scale for adjusting vertical scale osd_car_sbar_scale = 2 Allowed range: 1 - 4 Default value: 2

-CAR Sidebar angle 1/5 osd_car_sbar_low = 30 Allowed range: -99 - 99 Default value: 30

-CAR Sidebar angle 2/5 osd_car_sbar_mid_low = 15 Allowed range: -99 - 99 Default value: 15

-CAR Sidebar angle 3/5 osd_car_sbar_mid = 0 Allowed range: -99 - 99 Default value: 0

-CAR Sidebar angle 4/5 osd_car_sbar_mid_high = 15 Allowed range: -99 - 99 Default value: 15

-CAR Sidebar angle 5/5 osd_car_sbar_high = 30 Allowed range: -99 - 99 Default value: 30

MedlinDrone avatar Oct 24 '23 14:10 MedlinDrone

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

github-actions[bot] avatar Oct 24 '23 14:10 github-actions[bot]

https://github.com/betaflight/betaflight-configurator/assets/89054758/1e4ea5a5-901a-48dc-8cfd-eeb19fb520ce

MedlinDrone avatar Oct 24 '23 15:10 MedlinDrone

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Nov 13 '23 15:11 sonarqubecloud[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

github-actions[bot] avatar Dec 14 '23 04:12 github-actions[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

github-actions[bot] avatar Jan 15 '24 04:01 github-actions[bot]