betaflight-configurator icon indicating copy to clipboard operation
betaflight-configurator copied to clipboard

Added STICK_COMMAND_EXECUTED beeper condition.

Open zvonler opened this issue 2 years ago • 9 comments

First time contributor, these are changes to make available an optional beep when stick commands are executed. I did my best with the localization to mimic the grammar of the existing messages in the non-English locales.

BF changes to add feature: https://github.com/betaflight/betaflight/pull/13069

zvonler avatar Sep 06 '23 00:09 zvonler

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> FAIL
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

blckmn avatar Sep 06 '23 02:09 blckmn

You don't need to make the translations. They will be lost when we pull the translations files from Crowdin. Only English messages must be part of any PR.

McGiverGim avatar Sep 06 '23 07:09 McGiverGim

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

github-actions[bot] avatar Sep 06 '23 13:09 github-actions[bot]

You don't need to make the translations. They will be lost when we pull the translations files from Crowdin. Only English messages must be part of any PR.

Ah, that makes sense. I'll take out the other languages.

zvonler avatar Sep 06 '23 13:09 zvonler

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 06 '23 13:09 sonarqubecloud[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

github-actions[bot] avatar Oct 07 '23 04:10 github-actions[bot]

do we want to gate this feature with some USE_ ? and if so how to account in Configurator?

edit: nevermind, i see how it works now,

nerdCopter avatar Oct 07 '23 15:10 nerdCopter

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

github-actions[bot] avatar Nov 07 '23 04:11 github-actions[bot]

Should still be viable.

zvonler avatar Nov 09 '23 23:11 zvonler

Closing as firmware PR got stalled.

haslinghuis avatar Aug 21 '24 16:08 haslinghuis