betaflight-configurator
betaflight-configurator copied to clipboard
Added STICK_COMMAND_EXECUTED beeper condition.
First time contributor, these are changes to make available an optional beep when stick commands are executed. I did my best with the localization to mimic the grammar of the existing messages in the non-English locales.
BF changes to add feature: https://github.com/betaflight/betaflight/pull/13069
AUTOMERGE: (FAIL)
- github identifies PR as mergeable -> FAIL
- assigned to a milestone -> FAIL
- cooling off period lapsed -> PASS
- commit count less or equal to three -> PASS
Don't mergelabel NOT found -> PASS- at least one
RN:label found -> FAIL Testedlabel found -> FAIL- assigned to an approver -> FAIL
- approver count at least three -> FAIL
You don't need to make the translations. They will be lost when we pull the translations files from Crowdin. Only English messages must be part of any PR.
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
You don't need to make the translations. They will be lost when we pull the translations files from Crowdin. Only English messages must be part of any PR.
Ah, that makes sense. I'll take out the other languages.
Kudos, SonarCloud Quality Gate passed! 
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.
do we want to gate this feature with some USE_ ?
and if so how to account in Configurator?
edit: nevermind, i see how it works now,
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.
Should still be viable.
Closing as firmware PR got stalled.