betaflight-configurator
betaflight-configurator copied to clipboard
betaflight
Added new DSHOT debug modes
This pr matches functionality in https://github.com/betaflight/betaflight/pull/12170 and https://github.com/betaflight/betaflight/pull/11694
Added new DSHOT EDT modes to blackbox tab. As their names are longer than usual I made the drop down list controls wider. Also added FAILSAFE mode I found in blackbox explorer.
It can be used with Bluejay 0.20.1 RC2 or above.
Depends on https://github.com/betaflight/betaflight/pull/12170
Something is wrong, you are modifying a lot of files, including different languages files.
@McGiverGim This pr adds:
- Extended dshot telemetry (EDT) checkbox enable in motors tab, so translation files need to be updated (https://github.com/betaflight/betaflight/pull/11694)
- New debug modes to include (https://github.com/betaflight/betaflight/pull/12170): -- ESC temperature -- voltage -- current -- demag event -- desync event -- stall event -- demag metric max -- demag metric current -- other ESC debugging signals
- Sensors/debug functionality with new debug modes (https://github.com/betaflight/betaflight/pull/12170)
This is a work in progress/draft pr. Other functionality may be added over time.
@McGiverGim I am new at adding new features to Configurator, so I may be breaking some rules I don't know. Please, could you let me know why is this wrong?
You don't must change the locales files, only the English one. The translations are made at Crowdin and will update the others languages automatically.
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Kudos, SonarCloud Quality Gate passed! 
0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells
No Coverage information
0.0% Duplication
![sonarqubecloud[bot] avatar](https://avatars.githubusercontent.com/in/12526?v=4 "Published by a pub.dev verified publisher"){kind=small}
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
AUTOMERGE: (FAIL)
- github identifies PR as mergeable -> FAIL
- assigned to a milestone -> PASS
- cooling off period lapsed -> PASS
- commit count less or equal to three -> PASS
Don't mergelabel NOT found -> PASS- at least one
RN:label found -> PASS Testedlabel found -> FAIL- assigned to an approver -> FAIL
- approver count at least three -> FAIL
Today I generated a log in a Meteor 65 and it seems the pr works fine: STATUS_N_RPM_BTFL_BLACKBOX_LOG_Meteor65_20230318_104401.zip
Tested using the following prs & Bluejay v0.19.2: https://github.com/betaflight/betaflight/pull/12170 https://github.com/betaflight/betaflight-configurator/pull/3262 https://github.com/betaflight/blackbox-log-viewer/pull/625
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
The objective of this branch is allowing to log esc events in the blackbox to know how well commutation goes in the escs. I can work in the rebase, but at this time Bluejay is the only fw that fully implements extended telemetry and it seems that no other firmwares are interested in implementing it, neither any company, so if you like I could keep a branch in my own repo for BF4.5 and then we can let it go. Probably this is not the time for this class of innovation.
The objective of this branch is allowing to log esc events in the blackbox to know how well commutation goes in the escs. I can work in the rebase, but at this time Bluejay is the only fw that fully implements extended telemetry and it seems that no other firmwares are interested in implementing it, neither any company, so if you like I could keep a branch in my own repo for BF4.5 and then we can let it go. Probably this is not the time for this class of innovation.
If it’s ready passes code review and you will make use of it then I say let’s go.. I’m sure I can convince am32 to get on it and venders too
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
Thanks for keeping active here. I look forward to testing this with a suitable bluejay version. Would it be possible to include a link in the opening comment to a suitable ESC firmware to test with?
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
Quality Gate failed
Failed conditions
4.3% Duplication on New Code (required ≤ 3%)
See analysis details on SonarCloud
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
