betaflight-configurator icon indicating copy to clipboard operation
betaflight-configurator copied to clipboard

Chore/move gui to modules

Open chmelevskij opened this issue 2 years ago • 4 comments

  • refactor GUI to be class based
  • use import instead of global where possible
  • use esm module for gui.js

chmelevskij avatar Aug 19 '22 21:08 chmelevskij

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Aug 21 '22 05:08 sonarqubecloud[bot]

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

blckmn avatar Aug 21 '22 07:08 blckmn

I think I don't receive a mail when changed from draft to ready to review. It seems ok to me.

McGiverGim avatar Sep 15 '22 14:09 McGiverGim

Android build is failing as other builds are cancelled.

haslinghuis avatar Sep 15 '22 16:09 haslinghuis

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Dec 28 '22 19:12 sonarqubecloud[bot]

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

github-actions[bot] avatar Dec 28 '22 19:12 github-actions[bot]