betaflight-configurator icon indicating copy to clipboard operation
betaflight-configurator copied to clipboard

vtx_osd_variant_fix

Open P-I-Engineer opened this issue 3 years ago • 7 comments

this is a PR to replace https://github.com/betaflight/betaflight-configurator/pull/2755 i had too many github issues to salvage

I've created an osd variant for VTX channel that displays only the VTXpower.

pull request is partial approved in betaflight here https://github.com/betaflight/betaflight/pull/11275

image image image

P-I-Engineer avatar Jun 28 '22 19:06 P-I-Engineer

i know this is messed up again, i'm having a heck of a time with squashing commits

P-I-Engineer avatar Jun 28 '22 22:06 P-I-Engineer

@P-I-Engineer please check https://github.com/betaflight/betaflight/wiki/Betaflight-Contribution. You need to master this.

haslinghuis avatar Jun 28 '22 22:06 haslinghuis

i keep getting merge commits and not sure where they're coming from

P-I-Engineer avatar Jun 28 '22 22:06 P-I-Engineer

got it

P-I-Engineer avatar Jun 28 '22 23:06 P-I-Engineer

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jun 28 '22 23:06 sonarqubecloud[bot]

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

blckmn avatar Jun 29 '22 02:06 blckmn

Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

github-actions[bot] avatar Jul 05 '22 19:07 github-actions[bot]