betaflight-configurator
betaflight-configurator copied to clipboard
betaflight
scanning for elrs network devices with crsf msp frame capability
In future ELRS there is CRSF MSP support.
This contains 2 parts because a elrs rx can connect to home wifi or start a access point mode
- home wifi in this mode the elrs rx responds to mdns requests and sends 3 responses (A, TXT, SRV), with those i can make a valid tcp port
- ap mode in the latest ELRS master - the mdns is fixed, so i rely on that there too
To check if the connection is still valid we have a "down" event from the mdns browser, but thats not realy reliable, so i poll if a http connection can be made every 5 seconds, this check is skipped, when the GUI is connected to a device.
I've mentioned this in Discord but I'll drop it here for the Betaflight folks' info. This should not be using the hostname as the key (which can change). It should use the mDNS TXT records returned from the query vendor = elrs and type = rx to determine if the target is suitable.
I've mentioned this in Discord but I'll drop it here for the Betaflight folks' info. This should not be using the hostname as the key (which can change). It should use the mDNS TXT records returned from the query
vendor = elrsandtype = rxto determine if the target is suitable.
Yes, I will implement that once we sorted AP mode out 👍
AUTOMERGE: (FAIL)
- github identifies PR as mergeable -> FAIL
- assigned to a milestone -> PASS
- cooling off period lapsed -> PASS
- commit count less or equal to three -> PASS
-
Don't mergelabel NOT found -> PASS - at least one
RN:label found -> PASS -
Testedlabel found -> PASS - assigned to an approver -> PASS
- approver count at least three -> FAIL
While I can't vouch for anything regarding the appropriateness of how this fits into the configurator's scanning pattern, I can say that the ELRS detection from the mDNS responses gets my full approval. This old incorrect comment should be removed though since it no longer does this
// check if any of the answers on the response have a name that starts with
// 'elrs_', which indicates that it is an elers device
i refactored to another package which is now event based, so no timer anymore.
With the current ELRS master, the need of pinging a constant is obsolete.
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
Kudos, SonarCloud Quality Gate passed! 
0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells
No Coverage information
0.0% Duplication
![sonarqubecloud[bot] avatar](https://avatars.githubusercontent.com/in/12526?v=4 "Published by a pub.dev verified publisher"){kind=small}
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
expressLRS v3 RC is approaching rapidly, would be good to get this included in BF configurator so WiFi connection can be tested easily.
package-lock.json probably should not be added to the PR? Please also make sure you have only 1 commit per PR (squash, amend etc)
i removed the lock file
@freasy please rebase and squash
i rebased current master and squashed to 1 commit
the android part still needs testing - i couldnt do the test, because remote chrome debug wasnt catching the bf app's chromium
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
Checked out the branch but it's not working (Hangs at loading as PortHandler can't be initialized) Second just running in development it produces changes to yarn.lock which should be included in the PR.
Trying to build I get:
$ rm -rf cache
$ rm -rf dist
$ rm -rf debug
$ rm -rf node_modules
$ yarn && yarn start
yarn install v1.22.17
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
error Command failed.
Exit code: 128
Command: git
Arguments: ls-remote --tags --heads ssh://[email protected]/adam-lynch/node-temp.git
Directory: /home/mark/dev/betaflight/betaflight-configurator
Output:
Host key verification failed.
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
Tested - Linux is working but Android isn't detecting anything, sits at "Loading"
@freasy by moving some initialization from global scope to modules initialization function with this diff you can use GUI.isCordova()
diff.txt
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell
No Coverage information
0.0% Duplication
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
@freasy would like to continue working on this (need a rebase).
Yes of course! I will rebase it, what is missing so far, I think Android got tested and verified working right?
@freasy would like to continue working on this (need a rebase).
Yes of course! I will rebase it, what is missing so far, I think Android got tested and verified working right?
Last time I tested Android this was not working. I'll try the latest code.
@freasy would like to continue working on this (need a rebase).
Yes of course! I will rebase it, what is missing so far, I think Android got tested and verified working right?
Last time I tested Android this was not working. I'll try the latest code.
For me is working really, fine, but first we need to solve some not related issues in android.
@freasy please rebase so people are able to test.
@haslinghuis i rebased the current this branch onto the current master, i cant test it right now, i can do that later.
@freasy please can you review this now eLRS v3 is released?
i am currently on it
@howels @haslinghuis @chmelevskij
i removed helper.js, it seems like its not needed anymore. And i changed some bonjour code, because the "update" call was not functioning anymore (dont know why) but now its fine again.