betaflight-configurator
betaflight-configurator copied to clipboard
betaflight
Cli tab: added Save button
By @ctzsnooze request adding "Save" button. Technically its a new feature, so need to think about adding to 10.8. But it's a very small change.
The "Cancel" button is not needed cuz (by @KarateBrot) users can just click disconnect or to any other tab. Renamed Save/Load to File to Import/Export from/to file
I like the idea of a "Save" button. But do we really need the "Cancel" button? We can already quit the CLI if we click another tab or click "Disconnect". We could save one "Cancel" button to not overdo it with a wall of buttons.
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
I like the idea of a "Save" button. But do we really need the "Cancel" button? We can already quit the CLI if we click another tab or click "Disconnect". We could save one "Cancel" button to not overdo it with a wall of buttons.
Agree. Removed :)
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
Kudos, SonarCloud Quality Gate passed! 
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.1% Duplication
![sonarqubecloud[bot] avatar](https://avatars.githubusercontent.com/in/12526?v=4 "Published by a pub.dev verified publisher"){kind=small}
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
The text doesn't need to be so verbose.
| Current | Suggested | Comment |
|---|---|---|
| Copy to Clipboard | Copy | Where else could we copy too? |
| Clear output history | Clear | What else would we clear? |
| Export to File | Export | What else would we export too? |
| Import from File | Import | What else would we import from? |
If we are going to start again to change texts, please stop this until the new version of the Configurator. Any change of text invalidate the translations, and all the translators must translate it again.
If we are going to start again to change texts, please stop this until the new version of the Configurator. Any change of text invalidate the translations, and all the translators must translate it again.
good call. I will revert the text changes.
This isn't a bug fix for 4.3, it was just something that I know people found a bit confusing.
How about we try to make the changes 'really good', but mark them for the 4.4 / 10.9 milestone, not 4.3?
This isn't a bug fix for 4.3, it was just something that I know people found a bit confusing.
How about we try to make the changes 'really good', but mark them for the 4.4 / 10.9 milestone, not 4.3?
yeah, whatever works :)
AUTOMERGE: (FAIL)
- github identifies PR as mergeable -> FAIL
- assigned to a milestone -> PASS
- cooling off period lapsed -> PASS
- commit count less or equal to three -> PASS
Don't mergelabel NOT found -> PASS- at least one
RN:label found -> PASS Testedlabel found -> FAIL- assigned to an approver -> PASS
- approver count at least three -> FAIL
