betaflight-configurator
betaflight-configurator copied to clipboard
Test throttle selector UI component
This is a UI component for selecting throttle value in the motor setup dialogs. Currently it is not functional in the sense that throttle value changes do not take effect because actual motor control is better understood by @limonspb so take this as half-baked strictly UI feature to free limon from the hassle of dealing with HTML/CSS.


@atomgomba
the picture, plus check a couple of sonar warnings plz here

This PR seems a needed fix to make the new motor order dialog working properly since latest changes on how idle works on firmware. So i have asigned to 10.8.0 milestone.
Windows enviroment builds are failing here:
D:\a\1\s\src\components\shared\TestThrottleSelector\TestThrottleSelectorComponent.js 4:26 error Parsing error: Unexpected token =
yeah i think our Chrome version is not supporting static variables yet.
It's a pitty but it seems like if the supported ECMA version is different in the test env than the app? 😳
It's a pitty but it seems like if the supported ECMA version is different in the test env than the app? 😳
When I started working on presets I also wanted to use static class variables. But after some compatibility researsh I found I'd better not to yet. I don't remember why tho :) maybe because this standard has not been officially released yet, or something like that.
So all my static class variables I made like that, after the class closing bracket: MyClass.MyVariable = value; Works the same as static variable.
AUTOMERGE: (FAIL)
- github identifies PR as mergeable -> FAIL
- assigned to a milestone -> PASS
- cooling off period lapsed -> PASS
- commit count less or equal to three -> PASS
Don't mergelabel NOT found -> PASS- at least one
RN:label found -> PASS Testedlabel found -> FAIL- assigned to an approver -> FAIL
- approver count at least three -> FAIL
See: https://chromestatus.com/feature/6482797915013120
We are using:
navigator.appVersion.match(/.*Chrome\/([0-9\.]+)/)[1];
"91.0.4472.114"
According to NW.js we should be on Node 16.4.0 already:
{
"version": "v0.54.1",
"date": "2021/07/02",
"files": ["win-x64", "win-ia32", "linux-x64", "linux-ia32", "osx-x64"],
"flavors": ["normal", "sdk"],
"components": {
"node": "16.4.0",
"chromium": "91.0.4472.114"
}
},
Kudos, SonarCloud Quality Gate passed! 
0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells
No Coverage information
0.1% Duplication
I cannot merge for some reason
I cannot merge for some reason
what do you mean?
Kudos, SonarCloud Quality Gate passed! 
0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells
No Coverage information
0.0% Duplication
Do you want to test this code? Here you have an automated build: Betaflight-Configurator-Android Betaflight-Configurator-Linux Betaflight-Configurator-macOS Betaflight-Configurator-Windows WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!
@atomgomba there is no need for this PR as I talked with @limonspb