betaflight-configurator
betaflight-configurator copied to clipboard
betaflight
Add OSD_TOTAL_PACKS (with betaflight/pull/10808)
Add OSD_TOTAL_PACKS
Satisfies Needs coordination with betaflight-configurator label on the original PR #10808.
I tested the betaflight-configurator on Linux64 platform, and with modified Betaflight 4.3 (the one in PR) on STM32F7X2 target
# config: manufacturer_id: AIKO, board_name: AIKONF7, version: 34f72565, date: 2019-10-03T17:08:47Z
All settings went good on BF configurator and seems OK.
I'll test the feature itself this weekend ; all is looking good on the betaflight-configurator side.
yarn
yarn test
yarn start
Feature tested on BF side (see original PR)
Reviews required by @Asizon have been made.
@blckmn not sure why GitHub identifies PR as not mergeable. Any insight for that ?
Accidently closed the PR alongside my rebase. Everything should work great right now. Please let me now. ~~Edit : damn. What now. I see rebase's changes in commit.~~
Kudos, SonarCloud Quality Gate passed! 
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
![sonarqubecloud[bot] avatar](https://avatars.githubusercontent.com/in/12526?v=4 "Published by a pub.dev verified publisher"){kind=small}
@bree29 please squash your commits. Attached Don't merge label awaiting merging of firmware part.
@bree29 - If you want this merged into 10.8, please squash your commits and indicate that you still think it is important.
Otherwise we will tag it for 10.9 and think about it after 4.3 / 10.8 are released.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.2% Duplication
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.1% Duplication
@bree29 - If you want this merged into 10.8, please squash your commits and indicate that you still think it is important.
Otherwise we will tag it for 10.9 and think about it after 4.3 / 10.8 are released.
Just in case my updates from upstream will be an issue (the "one commit" thing, that were 5 here), just as it was in the betaflight part, I followed the same solution to update it to HEAD & squash my commit. Since I must do something wrong in my rebase sequences.
Sorry for the inconvenience of having to re-approving it for merging.
Merging upstream changes does count as commit but is actually not when rebasing. Found out after using letting vscode to do this for me. So I'm back on the command line.
AUTOMERGE: (FAIL)
- github identifies PR as mergeable -> FAIL
- assigned to a milestone -> PASS
- cooling off period lapsed -> PASS
- commit count less or equal to three -> PASS
Don't mergelabel NOT found -> PASS- at least one
RN:label found -> PASS Testedlabel found -> PASS- assigned to an approver -> FAIL
- approver count at least three -> FAIL
Firmware pr is labeled for 4.4,i think we are not in time to merge this new feature into 4.3
@limonspb , do I need to rebase before reviews are approved ? Same question for the firmware PR