betaflight-configurator icon indicating copy to clipboard operation
betaflight-configurator copied to clipboard

CLI AutoComplete missing some options

Open McGiverGim opened this issue 6 years ago • 2 comments

Using it, I usually use the command diff all defaults, one of the most useful of them for me... the automplete suggest diff but it does not suggest the all parameter (and of course it does not suggest the defaults at the end).

@Cleric-K can this be fixed or the FC does not give enough information? If it does not provide them, maybe it must be added to the info of the command in the FC.

McGiverGim avatar Sep 07 '19 14:09 McGiverGim

Looks like the FC does give enough information. 4.0.3

dump - dump configuration
	[master|profile|rates|hardware|all] {defaults|bare}

4.1.0

diff - list configuration changes from default
	[master|profile|rates|hardware|all] {defaults|bare}

Regex is dark dark magic.

Docteh avatar Sep 08 '19 05:09 Docteh

Just a comment, but from what I've noticed after a cursory glance through the code is that cli commands aren't missing per se, but likely not being added to the autocomplete value table because its hardware category isn't active or selected. I came across what I thought was a missing value when trying to set an i2c1_clockspeed_khz value. I wasn't getting the standard cli reply. Later I realized I hadn't enabled the magnetometer, and once that was done, the command showed up. Something tells me bad things would happen if users could start changing values for non-active entities. The alternative would be to always display everything, but non-entities would be marked with an asterisk (or greyed out an not selectable) to denote the option is there but can't or shouldn't be set. Just thinking out loud...

DHaacke avatar Feb 11 '22 01:02 DHaacke

Fixed in: https://github.com/betaflight/betaflight-configurator/pull/1677

haslinghuis avatar Jun 21 '23 18:06 haslinghuis