TwitchNoSub icon indicating copy to clipboard operation
TwitchNoSub copied to clipboard

No Bar to skip to specific time within VOD

Open JeffJeffrey12 opened this issue 2 years ago • 4 comments

Not sure why, but I can't see the bar to skip to a later part in VOD properly - only arrow keys work.

JeffJeffrey12 avatar Jul 13 '22 09:07 JeffJeffrey12

Hi, can you send me a screenshot of your player

besuper avatar Jul 14 '22 22:07 besuper

I just saw that it appear in fullscreen, but not when not fullscreen. And I didn't find the option to show chat in options.

JeffJeffrey12 avatar Jul 14 '22 22:07 JeffJeffrey12

To enable the chat you need to click on the extension icon image then click on "Settings". You will see this: image

besuper avatar Jul 14 '22 22:07 besuper

So here we see the player controls are appearing correctly: image

But if I collapse the left sidebar, the player gets bigger but you can see the bottom of the stream is cut off, along with the player controls: image

Rickkwa avatar Jul 28 '22 02:07 Rickkwa

Issue is caused by plyr. I do not know why the switch from videojs to plyr was made but I have reverted to videojs and this issue does not happen to me.

IMO plyr is outdated and not maintained anymore and hence videojs should be preferred. I also have observed memory leaks with plyr and some UI scaling issues which are not happening after going back to videojs.

I liked the support of playing "highlights" vod so I added support for those type of vod into previous code of v3 which is based on videojs so I'm not really missing anything.

ashishkotnala29 avatar Aug 15 '22 12:08 ashishkotnala29

Hey, the main reason to switch to plyr was to support firefox. It was easier for me to completely change the player instead of keeping videojs for firefox. But I switched back to videojs with partial support of firefox.

besuper avatar Aug 15 '22 19:08 besuper

That's great @besuper thanks!

ashishkotnala29 avatar Aug 15 '22 19:08 ashishkotnala29