rt icon indicating copy to clipboard operation
rt copied to clipboard

correctly handle logically empty simple searches (i.e. any)

Open gkleen opened this issue 2 years ago • 1 comments

Our users expect that typing any in simple search returns a list of all tickets; this also conforms to the inline documentation for the simple search feature.

During parsing the query any is mapped to the empty string. Thus all following "truthiness" checks treat the query as falsy, returning extremely unhelpful error messages instead of results.

This PR substitutes a default catch-all query iff the query is empty due to parsing. A truely empty query is cought earlier.

gkleen avatar Oct 28 '21 15:10 gkleen

Looks like this PR can resolve https://rt.bestpractical.com/Ticket/Display.html?id=36902

elacour avatar Oct 29 '21 08:10 elacour

A similar fix has been merged to 5.0-trunk, I'm closing this pull request.

Thanks!

-sunnavy

sunnavy avatar Dec 12 '22 20:12 sunnavy