FeatureDataCollector should not be registered in kernel debug mode

[ndench]

After upgrading to version 4.3 which hides the TraceableDataCollector when APP_DEBUG=0 (https://github.com/bestit/flagception-bundle/pull/89), I now get the following error when running tests with debug mode disabled:

TypeError: Flagception\Bundle\FlagceptionBundle\Profiler\FeatureDataCollector::__construct(): Argument #1 ($chainActivator) must be of type Flagception\Bundle\FlagceptionBundle\Activator\TraceableChainActivator, Flagception\Activator\ChainActivator given

I think that maybe the FeatureDataCollector should not be registered when debug mode is disabled? Or perhaps it just needs the data_collector tag removed?

[yakobe]

Is there any work around for this error? At the moment it seems i cannot turn debug mode off 😕

[ndench]

I haven't found one. Although I'll admit I haven't looked very hard either. I just locked to a previous version.

I'm happy to submit a PR to fix it if someone can point me in the right direction.

[vitsadecky]

Hi.

temporary solution is forced service registration: Flagception\Bundle\FlagceptionBundle\Activator\TraceableChainActivator

flagception.activator.chain_activator:
      class: Flagception\Bundle\FlagceptionBundle\Activator\TraceableChainActivator