sveltestrap icon indicating copy to clipboard operation
sveltestrap copied to clipboard
verified publisher icon bestguy

Svelte4 and Storybook7 fixes

Open kefahi opened this issue 2 years ago • 1 comments

This is more of a maintenance PR by which me and my colleague were able to update to Svelte4, Storybook7 and all deprecated packages.

  • This was tested on my project (CMS system called DMART)
  • The Storybook compiles and runs successfully. (npm run docs/start)
  • CI checks pass successfully as well (supporting nodejs 18 and 20).

Given that Svelte3 support is not maintained in this PR, and if it is accepted, we may consider making a major release ... e.g. 6.0 rc

kefahi avatar Oct 15 '23 14:10 kefahi

The formatting in this PR is all over the place. Mixes of double quotes and single quotes, unindented code, etc.

I think it'd be better to separate the Svelte 4 and Storybook 7 PRs to make them easier to review. This PR is 200 files, which is quite large

Also, what's the difference between your Svelte 4 changes and https://github.com/bestguy/sveltestrap/pull/574?

benmccann avatar Oct 31 '23 16:10 benmccann