Ironmon-Tracker icon indicating copy to clipboard operation
Ironmon-Tracker copied to clipboard

Published 20 hours ago • verified publisher icon besteon

Battle effects screen

Open jtigues opened this issue 1 year ago • 3 comments

  • Adds a new screen to the Tracker during trainer battles. Accessed by clicking on the pokeball icons when viewing an enemy mon
  • The screen can show Statuses of individual mons, as well as effects applied to either side of the battle, and the whole battle. User can switch between the different views by
  • The screen allows users to see passive Battle Effects which the game has notified them of, but cannot otherwise be reminded of once the next turn starts.
  • Some examples: Weather conditions, Leech Seed and which mon will receive the HP, Taunt, Encore, Confusion, Reflect/Light Screen, pending Future Sight attacks, or the number of times an enemy has successfully Protected consecutively. image

There is one known and incredibly minor bug I have not been able to sort out: I cannot for the life of me get the text & buttons to appear with shadows, and it seems it should work fine enough. But functionally, everything works fine across Games and Languages. Another note: the plan is eventually to have the Last Move used by each pokemon displayed separately here. But that framework is not in place yet, so it just shows the Last Move used as recorded by the Last Damage framework Also, I don't know where this expYield removal change came from, if I need to go in and manually re-add all of those that's fine.

jtigues avatar Oct 24 '23 02:10 jtigues

Few small things I've noticed looking back over it:

  • "stale" flag is no longer used but still has references
  • BattleEffectsScreen Button is being drawn unnecessarily, the button is invisible
  • Left Arrow pixel image has an extra column of 0s, it's actually 10 by 9.

jtigues avatar Oct 24 '23 03:10 jtigues

Few small things I've noticed looking back over it:

  • "stale" flag is no longer used but still has references
  • BattleEffectsScreen Button is being drawn unnecessarily, the button is invisible
  • Left Arrow pixel image has an extra column of 0s, it's actually 10 by 9.

Fixed

jtigues avatar Oct 24 '23 13:10 jtigues

expYield has been added back in, and the various concerns with the syntax/formatting have been resolved.

Also added the text strings to the non-English files, oops.

jtigues avatar Oct 24 '23 19:10 jtigues