flutter_swiper icon indicating copy to clipboard operation
flutter_swiper copied to clipboard

Migrate to Null Safety

Open Arkangel12 opened this issue 3 years ago • 25 comments

I help a little bit by migrating this package to null safety please take a look.

I copy the code from your other packages (they were too old) and added in this one, the others can be migrated later I just have enough time to do it like this.

please double-check if it is ok to move this to version 2.0.0 this was a huge refactor and some code was enhanced (I added pedantic) but it also can only be changed to 1.2.0 i leave this to you.

let me know what do you think 👍

running with null safety

Arkangel12 avatar Mar 15 '21 20:03 Arkangel12

+1

allanwolski avatar Mar 24 '21 22:03 allanwolski

@jzoom can it be merged anytime soon? It is blocking my release

szymly avatar Apr 09 '21 12:04 szymly

@Arkangel12 Could you pls publish the package onto pub.dev? The repo owner may not continue the repo anymore.

Nobler avatar May 10 '21 10:05 Nobler

@jzoom, @pepsighan, @iChenLei, @jogboms

Could anyone review and merge this PR please?

allanwolski avatar May 10 '21 17:05 allanwolski

Any chance to get this merged soon? It's one of the dependencies holding me up from migrating to null-safety.

emlynmac avatar May 10 '21 22:05 emlynmac

@allanwolski @szymly @emlynmac @Nobler I am tring to contact with jzoom, and push the merge action as soon as possible.

iChenLei avatar May 11 '21 01:05 iChenLei

@iChenLei Any updates?

Nobler avatar May 13 '21 02:05 Nobler

2021-05-13 11 07 02

@Nobler It's hard to contact with @jzoom ,and I found him in the QQ(Tencent QQ) paltform finally. I am negotiating with him, but no promised that i can push the merge action.

iChenLei avatar May 13 '21 03:05 iChenLei

2021-05-13 11 07 02

@Nobler It's hard to contact with @jzoom ,and I found him in the QQ(Tencent QQ) paltform finally. I am negotiating with him, but no promised that i can push the merge action.

Many thanks anyway. I will temporarily depend directly on the package stored in @Arkangel12 Github. Any others can do that before this pr will be merged:

flutter_swiper:
  git:
    url: [email protected]:Arkangel12/flutter_swiper.git
    ref: master

Nobler avatar May 13 '21 03:05 Nobler

@Nobler @allanwolski @Arkangel12 @emlynmac I am sorry to say this PR is look likes can't be merged. Please use alternative solution(e.g. flutter_swiper_null_safety or other swiper library) or use this workaround suggestion https://github.com/best-flutter/flutter_swiper/pull/264#issuecomment-840265874.

I contact with jzoom first time at 2021.05.13. After two weeks he still not merge this PR.

  1. He has no time to maintain opensource project
  2. He forgot his Github Account password.

So I left this comment for everyone who need flutter-swiper and null-safety support, please use alternative solution. Thanks

iChenLei avatar May 26 '21 09:05 iChenLei

@iChenLei Thank you so much for your help! This pr will be merged soon, I guess.👀

哈哈,难为你了,忍不住用母语感谢你。目前看应该还有希望。👀

Nobler avatar May 26 '21 16:05 Nobler

@iChenLei @jzoom he could just upload a fixed version to pub, no need for github 😅️ maybe it would be worth thinking about proposing the package to be transferred to https://github.com/fluttercommunity/transfer-guide 🤔️

hpoul avatar May 30 '21 20:05 hpoul

any updates on this?

nmzz209741 avatar Jun 04 '21 14:06 nmzz209741

This is died it seems.

SalahAdDin avatar Jun 04 '21 14:06 SalahAdDin

I have forked this repo and merged most of PRs into it (including this one). You can find the package here: https://pub.dev/packages/card_swiper

TheAnkurPanchani avatar Jun 07 '21 06:06 TheAnkurPanchani

I have forked this repo and merged most of PRs into it (including this one). You can find the package here: https://pub.dev/packages/card_swiper

Unfortunately, you have no open issues, it is working fine for now, but it still has some problems yets a we warned in two issues in another fork repository: https://github.com/pzentenoe/flutter_card_swipper/issues/4, https://github.com/pzentenoe/flutter_card_swipper/issues/3#issuecomment-854784632

SalahAdDin avatar Jun 07 '21 07:06 SalahAdDin

Thanks @SalahAdDin, I will have a look.

TheAnkurPanchani avatar Jun 07 '21 08:06 TheAnkurPanchani

@iChenLei @jzoom he could just upload a fixed version to pub, no need for github 😅️ maybe it would be worth thinking about proposing the package to be transferred to https://github.com/fluttercommunity/transfer-guide 🤔️

You can try the following version

dependencies: flutter_swiper_null_safety: ^1.0.2

lianyagang avatar Jun 10 '21 15:06 lianyagang

Thanks @SalahAdDin, I will have a look.

You can try the following version

dependencies: flutter_swiper_null_safety: ^1.0.2

lianyagang avatar Jun 10 '21 15:06 lianyagang

@iChenLei @jzoom he could just upload a fixed version to pub, no need for github 😅️ maybe it would be worth thinking about proposing the package to be transferred to https://github.com/fluttercommunity/transfer-guide 🤔️

You can try the following version

dependencies: flutter_swiper_null_safety: ^1.0.2

lianyagang avatar Jun 10 '21 15:06 lianyagang

@lianyagang @TheAnkurPanchani @pzentenoe why don't you try to gather all your sources and work on a unique fork?

SalahAdDin avatar Jun 11 '21 09:06 SalahAdDin

@lianyagang @TheAnkurPanchani @pzentenoe why don't you try to gather all your sources and work on a unique fork?

i think u can try use dependencies: flutter_swiper_null_safety: ^1.0.2

this pub gather all resource best wish for u

lianyagang avatar Jun 11 '21 09:06 lianyagang

Can anyone confirm if I can use this dependency 'flutter_swiper' with null-safety support? I saw in the dev pub that it doesn't support null-safety. How do I make it support null safety?

smith1996 avatar Aug 25 '21 19:08 smith1996

Can anyone confirm if I can use this dependency 'flutter_swiper' with null-safety support? I saw in the dev pub that it doesn't support null-safety. How do I make it support null safety?

use it flutter_swiper_null_safety: ^1.0.2

lianyagang avatar Aug 26 '21 02:08 lianyagang

@lianyagang thanks for the answer. The dependency that you suggest is a fork of "flutter_swiper"? What is your opinion about "card_swiper"?

smith1996 avatar Aug 26 '21 04:08 smith1996