libxcrypt icon indicating copy to clipboard operation
libxcrypt copied to clipboard

Man page edits

Open solardiz opened this issue 1 year ago • 5 comments
trafficstars

This is motivated by the criticism in https://www.openwall.com/lists/yescrypt/2024/03/21/1 that our wording "CPU time cost" was misleading, given that with memory-hard methods it also affects memory usage. That's addressed in the first commit here. The second commit is based on my proof-reading of the entire crypt.5.

Not yet changed here, but something we might also want to change, is renaming of the count parameter to cost. Perhaps not only in man pages, but also in code.

Edit: This also fixes #29

solardiz avatar Mar 27 '24 18:03 solardiz

This also fixes #29

solardiz avatar Mar 27 '24 19:03 solardiz

@vt-alt You might want to review my edits of the gost-yescrypt description here.

solardiz avatar Mar 28 '24 13:03 solardiz

@solardiz LGTM

vt-alt avatar Mar 28 '24 13:03 vt-alt

@besser82 @zackw Can you please merge this PR? I see no reason not to. You may say that more changes are desired, but that's no reason not to merge the changes so far. Thanks!

solardiz avatar Jun 03 '24 13:06 solardiz

I have not had time to look at these changes at all. Please be patient.

zackw avatar Jun 03 '24 13:06 zackw