libxcrypt icon indicating copy to clipboard operation
libxcrypt copied to clipboard

Fixes as recommended by codacy.

Open besser82 opened this issue 5 years ago • 3 comments

This is WIP. Do not merge, yet.

besser82 avatar Feb 25 '20 14:02 besser82

Codecov Report

Merging #101 into develop will increase coverage by 0.06%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #101      +/-   ##
===========================================
+ Coverage    94.27%   94.34%   +0.06%     
===========================================
  Files           32       32              
  Lines         3688     3765      +77     
===========================================
+ Hits          3477     3552      +75     
- Misses         211      213       +2     
Impacted Files Coverage Δ
lib/crypt-yescrypt.c 82.00% <0.00%> (-2.79%) :arrow_down:
lib/alg-sha1.c 100.00% <0.00%> (ø) :arrow_up:
lib/crypt-static.c 100.00% <0.00%> (ø) :arrow_up:
lib/alg-hmac-sha1.c 100.00% <0.00%> (ø) :arrow_up:
lib/crypt-des-obsolete.c 100.00% <0.00%> (ø) :arrow_up:
lib/alg-sha512.c 99.06% <0.00%> (+<0.01%) :arrow_up:
lib/alg-md5.c 99.28% <0.00%> (+0.01%) :arrow_up:
lib/alg-md4.c 99.19% <0.00%> (+0.01%) :arrow_up:
lib/crypt-sunmd5.c 98.34% <0.00%> (+0.01%) :arrow_up:
lib/alg-gost3411-2012-core.c 98.88% <0.00%> (+0.02%) :arrow_up:
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d2b3f02...836a732. Read the comment docs.

codecov[bot] avatar Feb 25 '20 14:02 codecov[bot]

Codacy Here is an overview of what got changed by this pull request:


Issues
======
+ Solved 1
           

See the complete overview on Codacy

besser82 avatar Feb 25 '20 14:02 besser82

Some Markdown processors attach semantic significance to whether or not there are blank lines between elements of a bullet list. (For instance, they render to HTML as <ul><li><p>...</p></li><li><p>...</p></li>...</ul> with blank lines and <ul><li>...</li><li>...</li>...</ul> without.) It doesn't especially matter for TODO.md but I'm concerned that Codacy is applying blanket style rules without taking this into account.

Also, a change that touches only TODO.md shouldn't have any effect on code coverage, do you have any idea why that happened?

zackw avatar Oct 12 '20 14:10 zackw