karma-jasmine-jquery icon indicating copy to clipboard operation
karma-jasmine-jquery copied to clipboard

Move bower and bower-installer to devDependencies

Open nkoder opened this issue 8 years ago • 8 comments

I've just noticed that in my project (which uses karma-jasmine-jquery) I get warning during npm install. This warning is about bower-installer not installed globally. And it comes as dependency of karma-jasmine-jquery.

Dev dependencies like bower shoudln't go into dependencies section of package.json to not pollute other projects which are using karma-jasmine-jquery. They should go into devDependencies section.

nkoder avatar May 27 '16 13:05 nkoder

+1

JenniferSpry avatar May 31 '16 14:05 JenniferSpry

+1

mbritton avatar Jun 17 '16 20:06 mbritton

Yeah... this actually makes karma-jasmine-jquery an 80MB dependency!!!

mhart avatar Jul 25 '16 19:07 mhart

Yes, and having the git:// protocol used in a dependency blocks installation in our corporate network. The firewall only allows port 443 and 80 outbound to Github!

ijabit avatar Oct 20 '16 15:10 ijabit

A security tool that audits our package.json complains about vulnerabilities in dependencies. It's complaining about the old dependencies in karma-jasmine-jquery that are being brought in from bower. For example, handlebars 2.0.0 has this vulnerability, CVE-2015-8861.

$ npm ls handlebars
[email protected]
└─┬ [email protected] (git+https://github.com/bessdsv/bower-installer.git#7f9cece1e6fada50f44dc0851e1d85815cd1b4a7)
  └─┬ [email protected]
    └── [email protected] 

Could you merge #16 and make a release if possible?

ashawley avatar Feb 10 '18 07:02 ashawley

yes , same issue as @ashawley . do some update stuff . man

insetavijit avatar Apr 06 '18 06:04 insetavijit

Any movement on this, @bessdsv ? That version of bower has been a critical security issue for a long time now, and there's no need to have it as a dependency.

nemoDreamer avatar Oct 23 '19 15:10 nemoDreamer

I solved bower dependency by uninstalling karma-jasmine-jquery package (it uninstalled bower and all its dependencies) and installed @metahub/karma-jasmine-jquery.

angezid avatar Feb 22 '23 04:02 angezid