Removed bower dependency

[AStoker]

removed unneeded bower dependency. https://github.com/bessdsv/karma-jasmine-jquery/issues/8

[jonhunter1977]

+1

[jamesmorgan]

:+1:

[jamlen]

:+1:

[julkue]

It is sad that I need to give a :+1: for an issue thas is known for almost a year.

[julkue]

@bessdsv If you aren't able to merge this important PR and fix issues, could you please consider to add some contributors to do so?

[bessdsv]

I use those dependencies for installing last versions of internal libraries (jquery & jasmine-jquery) and make some magic. And i use github fork project because contributor of bower-installer project can't merge my pull request or other pull request with one feature what i need. I can delete dependencies but after that all people, who use this library, must upgrade libraries manually. or i must make new commits with new libraries' versions. do you have some ideas?

[AStoker]

You don't need to bring in Bower as a dependency. If you list the dependencies you need (such as jQuery and jasmine-jquery) in the package config (as well as the bower.json), then if you're pulling the library down with bower, jspm, or whatever, it should pull down any needed dependencies. And from what you're telling me, it sounds like you use bower as a dev-dependency, so in that case it definitely shouldn't be included. What goes out the the end use should only be what's needed for the actual project, ideally.

[AStoker]

Bump

[hansogj]

Totally agree with @AStoker . Would be nice to get rid of bower; and then allso the custom install-script of this, otherwise, well working plugin

[AStoker]

@bessdsv, any update? Is there any new development on this repo?

[julkue]

@AStoker if @bessdsv does not reply within 7 days, could you please fork this repository and fix that issue?

[AStoker]

@julmot, can do

[AStoker]

@julmot patch-1 branch of the fork has been merged with the master, and a release has been made. https://github.com/AStoker/karma-jasmine-jquery/ Registered under the name karma-jasmine-jquery-2 to avoid naming conflicts with the original (unfortunately). But you can download with with jspm, npm, or bower.

[AStoker]

@bessdsv if this ever get's merged in, I'll mark the branch I created as deprecated (but leave it up) and point it back to the master.

[julkue]

@bessdsv Take care of this issue.

[julkue]

@bessdsv Please also specify where exactly you need that bower dependency. I searched your code for any bower call unsuccessfully.

[AStoker]

bump

[djskinner]

Thanks @AStoker. I'm reviving an old project and this package was causing npm install to fail for me. Moving to karma-jasmine-jquery-2 fixed it right away.

[pvdlg]

If anyone's interested I published karma-jasmine-jquery. The package has no dependencies and let you choose your version of jasmine-core karma-jasmine jasmine-jquery.

[serbanghita]

You don't have to move anything, just fork, make the change and adapt your package.json. Here is how I fixed the dependency problem (after I made the changes):

"karma-jasmine-jquery": "[email protected]:serbanghita/karma-jasmine-jquery.git#master",

[ashvin777]

@bessdsv , can you merge either this PR or https://github.com/bessdsv/karma-jasmine-jquery/pull/16. There is a lot of npm audit error due to use of the older version of bower in dependencies. Below is the npm audit report -

found 29 vulnerabilities (7 low, 17 moderate, 4 high, 1 critical) in 30478 scanned packages
  29 vulnerabilities require manual review. See the full report for details.

Full Report - report.txt