Bessenyei Balázs Donát
Bessenyei Balázs Donát
Hi @JunLuo , Thank you for the changes! On a first pass, I've noticed that a new user guide entry is missing. For this change to get merged, some documentation...
Overall, this change looks fine to me. After receiving feedback for the comments I have left, I'd like to request contributors and committers to do a review of this PR...
> Is there a chance for it to get in if all the comments are addressed? I don't have the time and resources to do a proper review here, but...
+1 (non-binding)
@lew181818 : what kind of readme are you looking for? I don't think this has been merged yet. Also, the corresponding JIRA ticket is https://issues.apache.org/jira/browse/FLUME-2807 , I believe.
@lew181818 : if you are only looking for a documentation on the configuration, maybe https://github.com/apache/flume/pull/14/files#diff-4d9ec6998a1233dda992589304f831d4R67 should help. Please, let me know, if I misunderstood your request. Btw, if there is...
@hklarner : https://github.com/apache/couchdb/pull/3568 is very close to a merge. Do you want me to hold off with it so that this can be merged before?
> @bessbd no, because I won't be able to continue with this for at least another week. All I have to do to be up to date is pull before...
> @janl This is very stale. Any plans to get this in? I am preparing to mass-close old PRs that never got merged. @janl / @wohali : ping
Hi @iblis17, Thank you for this patch! Do you think you could include a test with this change?