f3dasm icon indicating copy to clipboard operation
f3dasm copied to clipboard

ExperimentData method to extract multiple samples by index.

Open mpvanderschelling opened this issue 2 years ago • 0 comments

Request to add a method to the ExperimentData object to extract multiple ExperimentSample objects by given a iterable of indices.

          Expected method to extract sample by index.

Please check the review comments on the code.

I suggest enriching this method to extract multiple samples (e.g., tuple[ExperimentSample]) from an iterable of indexes or create a new method (e.g., get_experiment_samples(...)) for this purpose. This is a simple improvement that avoids burdening the user with the task of implementing an explicit cycle to extract multiple samples.

Originally posted by @BernardoFerreira in https://github.com/bessagroup/f3dasm/pull/199#pullrequestreview-1701761605

mpvanderschelling avatar Oct 27 '23 15:10 mpvanderschelling