stable_diffusion.openvino icon indicating copy to clipboard operation
stable_diffusion.openvino copied to clipboard

Published 20 hours ago • verified publisher icon bes-dev

add toml file and poetry.lock

Open koji opened this issue 3 years ago • 3 comments

Add 2 files and this will close #27

  • pyproject.toml
  • poetry.lock

Poetry version 1.1.6

Usage

$ poetry install
$ poetry run python python_file

koji avatar Sep 03 '22 02:09 koji

Did you want to also remove the requirements.txt file to complete the transition and avoid having two sources of truth? It would probably also be nice to update the README to reflect the new preferred approach for installation.

after-ephemera avatar Sep 05 '22 20:09 after-ephemera

@jkjetty I think keeping requiremetns.txt is kind of good since that can give options. In addition, I'm not sure how popular poetry is, so that is the reason why I didn't add any information to the readme.

koji avatar Sep 05 '22 22:09 koji

@koji I will let the maintainer chime in here to make the final decision but I think poetry is well enough adopted in the community that it's worth dropping the requirements.txt file, even if that may mean some grace period of supporting both. Maintaining two declarations of dependencies over time is probably not a job any of us want to be doing.

after-ephemera avatar Sep 05 '22 23:09 after-ephemera